Page MenuHomeFreeBSD
Differential D17626

Add an assertion to pmap_enter().
ClosedPublic
Actions

Authored by markj on Oct 20 2018, 8:03 PM.
Tags
None
Referenced Files
F170098021: D17626.id49350.diff
Thu, Sep 3, 12:25 PM
F170017177: D17626.id49357.diff
Thu, Sep 3, 6:30 AM
F170015835: D17626.id49353.diff
Thu, Sep 3, 6:23 AM
Unknown Object (File)
Wed, Sep 2, 12:33 PM
Unknown Object (File)
Tue, Sep 1, 9:40 PM
Unknown Object (File)
Tue, Sep 1, 12:39 PM
Unknown Object (File)
Tue, Sep 1, 6:39 AM
Unknown Object (File)
Mon, Aug 31, 4:47 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS339490: Add an assertion to pmap_enter().
Summary

When faulting on an existing mapping, if the mapping is managed, it
should have a PV entry. Verify this.

I found this useful while debugging some modifications.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20309
Build 19767: arc lint + arc unit

Event Timeline

markj created this revision.Oct 20 2018, 8:03 PM
Harbormaster completed remote builds in B20308: Diff 49350.Oct 20 2018, 8:03 PM
markj added reviewers: alc, kib.Oct 20 2018, 8:05 PM
alc added inline comments.Oct 20 2018, 8:12 PM
sys/amd64/amd64/pmap.c
5065

Based on line 5047, (origpte & PG_MANAGED) == 0 can never be true.

markj updated this revision to Diff 49353.Oct 20 2018, 8:21 PM
markj marked 2 inline comments as done.
  • Address Alan's comment.
Harbormaster completed remote builds in B20309: Diff 49353.Oct 20 2018, 8:21 PM
markj added inline comments.Oct 20 2018, 8:21 PM
sys/amd64/amd64/pmap.c
5065

Thanks, I originally had this assertion further down.

kib accepted this revision.Oct 20 2018, 8:25 PM
This revision is now accepted and ready to land.Oct 20 2018, 8:25 PM
alc accepted this revision.Oct 20 2018, 8:27 PM
Closed by commit rS339490: Add an assertion to pmap_enter(). (authored by markj). · Explain WhyOct 20 2018, 8:53 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 8:53 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
2 lines
i386/
i386/
2 lines

Diff 49353

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/i386/i386/pmap.c

Loading...