Page MenuHomeFreeBSD

random(4): Translate a comment requirement into a compile-time invariant
ClosedPublic

Authored by cem on Sep 1 2018, 4:39 AM.
Tags
None
Referenced Files
F151951893: D16982.id.diff
Sat, Apr 11, 5:44 PM
F151913118: D16982.id.diff
Sat, Apr 11, 12:22 PM
Unknown Object (File)
Thu, Apr 9, 2:35 AM
Unknown Object (File)
Thu, Apr 9, 2:32 AM
Unknown Object (File)
Wed, Apr 8, 5:36 AM
Unknown Object (File)
Mon, Apr 6, 9:21 AM
Unknown Object (File)
Sun, Apr 5, 1:30 AM
Unknown Object (File)
Sat, Apr 4, 11:39 AM
Subscribers

Details

Summary

In various places, random represents the set of sources as a 32-bit word
bitmask. It assumes all sources fit within this, i.e., the maximum valid
source number is 31.

There was a comment specifying this limitation, but we can actually refuse
to compile if our assumption is violated instead. We still have a few spare
random source slots, but sooner or later someone may need to convert the
masks used from raw 32-bit words to bitset(9) APIs.

This prevents some kinds of developer foot-shooting when adding new random
sources. No functional change.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable