I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

As for me personally, I'm fine to type 'kldunload -f' when I do kernel hacking. A normal sysadmin shouldn't need to unload the module. If they really need (why?) then 'kldunload -f' is always available.

In D17505#379676, @glebius wrote:

I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

I'm not currently aware of any remaining issues here. It's certainly possible that some still exist, but I've seen no reports and the tests don't provoke them.
I think of this change mostly as a 'I will support this now.' statement.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2018, 5:01 PM

Closed by commit rS340070: pfsync: Allow module to be unloaded (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

if_pfsync.c

6 lines

Diff 48977

View Options

sys/netpfil/pf/if_pfsync.c

This file was copied to textproc/docproj-legacy/Makefile.

	# Created by: Nik Clayton <nik@FreeBSD.org>

	PORTNAME= docproj			PORTNAME= docproj
				hrsUnsubmitted Done Inline Actions Please remove this line. hrs: Please remove this line.
	PORTVERSION= 3.0			PORTVERSION= 4.0
	PORTREVISION= 1
	CATEGORIES= textproc			CATEGORIES= textproc

	MAINTAINER= doceng@FreeBSD.org			MAINTAINER= doceng@FreeBSD.org
	COMMENT= Meta-port for the FreeBSD Documentation Project			COMMENT= Meta-port for the FreeBSD Documentation Project

	RUN_DEPENDS= asciidoctor:textproc/rubygem-asciidoctor \			RUN_DEPENDS= asciidoctor:textproc/rubygem-asciidoctor \
	${LOCALBASE}/share/xml/dtd/xhtml/xhtml.soc:textproc/xhtml \
	${LOCALBASE}/share/xml/xmlcharent/catalog:textproc/xmlcharent \
	${LOCALBASE}/share/xsl/iso-schematron/xslt1/iso_schematron_skeleton_for_xslt1.xsl:textproc/iso-schematron-xslt \
	docbook-xsl-ns>=1.78.1_4:textproc/docbook-xsl-ns \
	docbook>0:textproc/docbook \
	hugo:www/gohugo \			hugo:www/gohugo \
	links:www/links1 \
	p5-XML-Parser>=2.41:textproc/p5-XML-Parser \
	peps:graphics/peps \
	pngtopnm:graphics/netpbm \
	rougify:textproc/rubygem-rouge \			rougify:textproc/rubygem-rouge \
	scr2png:graphics/scr2png \
	scr2txt:textproc/scr2txt \
	xsltproc:textproc/libxslt \
	zip:archivers/zip

	USES= ghostscript:run metaport perl5 python:3.6+,run			USES= metaport python:3.6+,run
	USE_PERL5= run

	OPTIONS_DEFINE= CJK DBLATEX FOP GIT GROFF IGOR JING PDF TRANSLATOR			OPTIONS_DEFINE= GIT IGOR PDF TRANSLATOR
	OPTIONS_DEFAULT= CJK GIT GROFF IGOR PDF TRANSLATOR			OPTIONS_DEFAULT= GIT IGOR PDF TRANSLATOR

	CJK_DESC= CJK support
	DBLATEX_DESC= dblatex PDF renderer (experimental, requires TeXLive)
	FOP_DESC= FOP PDF renderer (requires Java)
	GIT_DESC= Git support
	GROFF_DESC= Groff support from ports
	IGOR_DESC= Igor automated proofreader for documentation			IGOR_DESC= Igor automated proofreader for documentation
	JING_DESC= Jing for advanced RELAX NG validation
	TRANSLATOR_DESC= Tools for translators			TRANSLATOR_DESC= Tools for translators

	CJK_RUN_DEPENDS= html2text:textproc/html2text
	DBLATEX_RUN_DEPENDS= dblatex:textproc/dblatex
	DBLATEX_USE= TEX=xetex
	FOP_RUN_DEPENDS= ${_FONTS} \
	fop:textproc/fop
	GIT_RUN_DEPENDS= git:devel/git			GIT_RUN_DEPENDS= git:devel/git
	GROFF_USES= groff:run
	IGOR_RUN_DEPENDS= igor:textproc/igor			IGOR_RUN_DEPENDS= igor:textproc/igor
	hrsUnsubmitted Done Inline Actions Do we really want to remove Igor? Certainly, this does not support adoc, but this is still useful as a checker, and we should make it possible to recognize adoc in the long term. hrs: Do we really want to remove Igor? Certainly, this does not support adoc, but this is still…
	JING_RUN_DEPENDS= jing:textproc/jing
	PDF_RUN_DEPENDS= asciidoctor-pdf:textproc/rubygem-asciidoctor-pdf			PDF_RUN_DEPENDS= asciidoctor-pdf:textproc/rubygem-asciidoctor-pdf
	TRANSLATOR_RUN_DEPENDS= itstool:textproc/itstool \			TRANSLATOR_RUN_DEPENDS= po4a>=0.63_1:textproc/po4a
	msgcat:devel/gettext-tools \
	po4a>=0.63_1:textproc/po4a

	_FONTS= ${LOCALBASE}/share/fonts/dejavu/DejaVuSansMono.ttf:x11-fonts/dejavu \
	${LOCALBASE}/share/fonts/Droid/DroidSans.ttf:x11-fonts/droid-fonts-ttf \
	${LOCALBASE}/share/fonts/GentiumPlus/GentiumPlus-Regular.ttf:x11-fonts/gentium-plus \
	${LOCALBASE}/share/fonts/Lohit/Lohit-Bengali.ttf:x11-fonts/lohit
	_FONTS_CJK= ${LOCALBASE}/share/fonts/ipa/ipam.otf:japanese/font-ipa \
	${LOCALBASE}/share/fonts/nanum-ttf/NanumBarunGothic.ttf:korean/nanumfonts-ttf \
	${LOCALBASE}/share/fonts/TrueType/gkai00mp.ttf:chinese/arphicttf

	.include <bsd.port.options.mk>

	.if ${PORT_OPTIONS:MFOP} \|\| ${PORT_OPTIONS:MDBLATEX}
	ONLY_FOR_ARCHS= amd64 i386
	CJK_RUN_DEPENDS+= ${_FONTS_CJK}
	.endif

	# generate MINIMALDOCPORTS for src/release/Makefile.inc.docports.
	# (XXX: incomplete yet)
	minimaldocports:
	@${ECHO_CMD} "MINIMALDOCPORTS= \\"
	@${MAKE} all-depends-list \| ${SED} -e 's,^${PORTSDIR}/, ,' -e 's,$$, \\,'

	.include <bsd.port.mk>			.include <bsd.port.mk>

pfsync: Allow module to be unloadedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48977

sys/netpfil/pf/if_pfsync.c

pfsync: Allow module to be unloaded
ClosedPublic
Actions

Revision Contents
Changeset List