Page MenuHomeFreeBSD

pfsync: Allow module to be unloaded
ClosedPublic

Authored by kp on Oct 10 2018, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 3:51 AM
Unknown Object (File)
Oct 3 2024, 1:08 AM
Unknown Object (File)
Oct 2 2024, 5:03 PM
Unknown Object (File)
Oct 2 2024, 4:56 AM
Unknown Object (File)
Oct 1 2024, 3:21 PM
Unknown Object (File)
Sep 24 2024, 4:00 PM
Unknown Object (File)
Sep 22 2024, 1:23 PM
Unknown Object (File)
Sep 19 2024, 10:09 AM

Details

Reviewers
None
Group Reviewers
network
Commits
rS340070: pfsync: Allow module to be unloaded

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20119
Build 19613: arc lint + arc unit

Event Timeline

I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

As for me personally, I'm fine to type 'kldunload -f' when I do kernel hacking. A normal sysadmin shouldn't need to unload the module. If they really need (why?) then 'kldunload -f' is always available.

I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

I'm not currently aware of any remaining issues here. It's certainly possible that some still exist, but I've seen no reports and the tests don't provoke them.
I think of this change mostly as a 'I will support this now.' statement.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 2 2018, 5:01 PM
This revision was automatically updated to reflect the committed changes.