Page MenuHomeFreeBSD
Differential D17278

Add more lowmem predicates.
ClosedPublic
Actions

Authored by markj on Sep 21 2018, 10:00 PM.
Tags
None
Referenced Files
F167891229: D17278.id48407.diff
Tue, Aug 25, 7:09 AM
Unknown Object (File)
Sat, Aug 22, 4:18 AM
Unknown Object (File)
Wed, Aug 19, 4:21 PM
Unknown Object (File)
Tue, Aug 18, 8:00 PM
Unknown Object (File)
Tue, Aug 18, 4:18 PM
Unknown Object (File)
Tue, Aug 18, 1:05 PM
Unknown Object (File)
Tue, Aug 18, 11:19 AM
Unknown Object (File)
Tue, Aug 18, 9:29 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
jeff
Commits
rS338919: Add more NUMA-specific low memory predicates.
Summary

Use these predicates instead of inline references to vm_min_domains.
Also add an all_domains set, akin to all_cpus; this can be used to check
whether all domains are below a threshold, e.g.,
vm_page_count_min(&all_domains).

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19740
Build 19300: arc lint + arc unit

Event Timeline

markj created this revision.Sep 21 2018, 10:00 PM
Harbormaster completed remote builds in B19737: Diff 48331.Sep 21 2018, 10:00 PM
markj added reviewers: alc, kib, jeff.Sep 21 2018, 10:01 PM
kib added inline comments.Sep 21 2018, 10:13 PM
sys/x86/acpica/srat.c
475

Wouldn't this initialize all_domains only on x86 ?

markj updated this revision to Diff 48334.Sep 21 2018, 10:23 PM
markj marked an inline comment as done.
  • Add a static initializer for all_domains.
Harbormaster completed remote builds in B19740: Diff 48334.Sep 21 2018, 10:23 PM
alc accepted this revision.Sep 21 2018, 10:34 PM
This revision is now accepted and ready to land.Sep 21 2018, 10:34 PM
kib accepted this revision.Sep 21 2018, 10:46 PM
jeff accepted this revision.Sep 24 2018, 6:52 PM

lgtm

Closed by commit rS338919: Add more NUMA-specific low memory predicates. (authored by markj). · Explain WhySep 24 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptSep 24 2018, 7:24 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
28 lines
vm/
16 lines
4 lines
1 line
x86/
acpica/
5 lines

Diff 48334

View Options

sys/sys/vmmeter.h

Loading...
View Options

sys/vm/vm_domainset.c

Loading...
View Options

sys/vm/vm_page.c

Loading...
View Options

sys/vm/vm_phys.c

Loading...
View Options

sys/x86/acpica/srat.c

Loading...