We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up.
ClosedPublic
Actions

Authored by imp on Sep 21 2018, 5:28 AM.

Details

Reviewers: None
Commits: rS338888: We don't need shell protection for when we're expanding matches.

Summary

PR: 231441

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19714
Build 19277: arc lint + arc unit

Event Timeline

imp created this revision.Sep 21 2018, 5:28 AM

Herald added a subscriber: asomers. · View Herald TranscriptSep 21 2018, 5:28 AM

Harbormaster completed remote builds in B19714: Diff 48292.Sep 21 2018, 5:28 AM

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

In D17267#367979, @johalun0_gmail.com wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Weird, works for me, and regex in Testing device-name line looks correct now without any changes to devd.conf. Make sure you are running correct binary?

In D17267#368025, @yuripv_yuripv.net wrote:

In D17267#367979, @johalun0_gmail.com wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Weird, works for me, and regex in Testing device-name line looks correct now without any changes to devd.conf. Make sure you are running correct binary?

Oh you're right. I accidentally scp'd the new file to /usr/sbin *_* Works fine now :)

In D17267#367979, @johalun0_gmail.com wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

No changes should be required. I'd double check you built right, or that I'm not applying things backwards.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2018, 3:33 PM

Closed by commit rS338888: We don't need shell protection for when we're expanding matches. (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.