Page MenuHomeFreeBSD

Mk/Uses/dos2unix.mk: Do not accept any arguments
ClosedPublic

Authored by tobik on Sep 12 2018, 1:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 3:05 PM
Unknown Object (File)
Sat, Dec 7, 9:51 AM
Unknown Object (File)
Fri, Dec 6, 2:03 PM
Unknown Object (File)
Oct 23 2024, 4:12 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 3:17 PM
Subscribers

Details

Reviewers
None
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP479778: Be more strict and let USES=dos2unix accept no arguments
Summary

In D16995 it was attempted to use something like

USES=	dos2unix:src/menu.cpp

to only apply dos2unix to ${WRKSRC}/src/menu.cpp. This is wrong and will
apply it to all files in ${WRKSRC} instead. It would be nice to if dos2unix
would print an error message in that case as some USES macros already do.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19589
Build 19171: arc lint + arc unit

Event Timeline

Mk/Uses/dos2unix.mk
16
IGNORE=
tobik marked an inline comment as done.

+= -> =

Before committing, please make sure it breaks no port.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2018, 6:27 PM
This revision was automatically updated to reflect the committed changes.