dos2unix.mk: Do not accept any arguments
ClosedPublic
Actions

Authored by tobik on Sep 12 2018, 1:57 PM.

Details

Reviewers

None

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP479778: Be more strict and let USES=dos2unix accept no arguments

Summary

In D16995 it was attempted to use something like

USES=	dos2unix:src/menu.cpp

to only apply dos2unix to ${WRKSRC}/src/menu.cpp. This is wrong and will
apply it to all files in ${WRKSRC} instead. It would be nice to if dos2unix
would print an error message in that case as some USES macros already do.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 19542
Build 19129: arc lint + arc unit

Event Timeline

tobik created this revision.Sep 12 2018, 1:57 PM

Owners added a reviewer: O5: Ports Framework.Sep 12 2018, 1:57 PM

Herald added a reviewer: portmgr. · View Herald TranscriptSep 12 2018, 1:57 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B19542: Diff 47953.Sep 12 2018, 1:57 PM

mat added inline comments.Sep 14 2018, 8:07 AM

Mk/Uses/dos2unix.mk
16	IGNORE=

+= -> =

Harbormaster completed remote builds in B19589: Diff 48038.Sep 14 2018, 8:31 AM

Before committing, please make sure it breaks no port.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2018, 6:27 PM

Closed by commit rP479778: Be more strict and let USES=dos2unix accept no arguments (authored by tobik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

dos2unix.mk

4 lines

Diff 47953

View Options

Mk/Uses/dos2unix.mk: Do not accept any argumentsClosedPublicActions