Page MenuHomeFreeBSD

Mk/Uses/dos2unix.mk: Do not accept any arguments
ClosedPublic

Authored by tobik on Sep 12 2018, 1:57 PM.
Tags
None
Referenced Files
F104343798: D17133.diff
Fri, Dec 6, 2:03 PM
Unknown Object (File)
Oct 23 2024, 4:12 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 4:11 PM
Unknown Object (File)
Oct 23 2024, 3:17 PM
Unknown Object (File)
Oct 3 2024, 5:12 PM
Unknown Object (File)
Oct 2 2024, 9:05 PM
Subscribers

Details

Summary

In D16995 it was attempted to use something like

USES=	dos2unix:src/menu.cpp

to only apply dos2unix to ${WRKSRC}/src/menu.cpp. This is wrong and will
apply it to all files in ${WRKSRC} instead. It would be nice to if dos2unix
would print an error message in that case as some USES macros already do.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mk/Uses/dos2unix.mk
16 ↗(On Diff #47953)
IGNORE=
tobik marked an inline comment as done.

+= -> =

Before committing, please make sure it breaks no port.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2018, 6:27 PM
This revision was automatically updated to reflect the committed changes.