[update] games/barony to 3.2.1

[devnexen_gmail.com]

Summary

• Update to current gog.com version
• shell script not necessary anymore, the game saving in user's home itself.

[devnexen_gmail.com]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231109

[mat]

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

[mat]

games/barony/files/pkg-message.in

6 ↗

(On Diff #47624)

Should this be changed too?

[devnexen_gmail.com]

Adding "hotfix" patch which unmounted one of the base folders before the application had a chance to load its contents.

I was able to push upstream this patch so it is correct.

[tobik]

games/barony/Makefile

14–17 ↗

(On Diff #47811)

Having these sorted would be nicer.

games/barony/files/patch-src_menu.cpp

1–11 ↗

(On Diff #47811)

• This patch has inconsistent line endings which SVN doesn't like. The source files some to have DOS-style line endings. You might have to apply USES=dos2unix to src/menu.cpp before patching it.

• Please use make makepatch to (re-)generate new patches in the future (also do it once for simple patches like this one if you copy them from somewhere else)

[devnexen_gmail.com]

games/barony/Makefile

14–17 ↗

(On Diff #47811)

Agreed.

games/barony/files/patch-src_menu.cpp

1–11 ↗

(On Diff #47811)

Thanks good to know.

[tobik]

games/barony/Makefile

20 ↗

(On Diff #47925)

The argument to dos2unix does nothing and dos2unix will be applied to all source files. I'm actually surprised that dos2unix even accepts an argument...

You need to set DOS2UNIX_FILES=src/menu.cpp instead if it should only be applied to src/menu.cpp. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html#slow-patch-automatic-replacements