Page MenuHomeFreeBSD
Differential D17154

rtld-elf: fix more warnings to allow compiling with WARNS=6
ClosedPublic
Actions

Authored by arichardson on Sep 13 2018, 2:52 PM.
Tags
None
Referenced Files
F165093308: D17154.diff
Wed, Aug 5, 11:37 PM
Unknown Object (File)
Thu, Jul 30, 4:32 PM
Unknown Object (File)
Jul 7 2026, 4:56 AM
Unknown Object (File)
Jul 7 2026, 4:55 AM
Unknown Object (File)
Jul 6 2026, 2:33 PM
Unknown Object (File)
Jul 5 2026, 6:01 PM
Unknown Object (File)
Jul 1 2026, 5:53 AM
Unknown Object (File)
May 25 2026, 8:33 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
brooks
Commits
rS339879: rtld-elf: fix more warnings to allow compiling with WARNS=6

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19568
Build 19153: arc lint + arc unit

Event Timeline

arichardson created this revision.Sep 13 2018, 2:52 PM
Harbormaster completed remote builds in B19568: Diff 48004.Sep 13 2018, 2:52 PM
kib accepted this revision.Sep 13 2018, 3:48 PM
This revision is now accepted and ready to land.Sep 13 2018, 3:48 PM
brooks accepted this revision.Sep 13 2018, 4:17 PM

LGTM

arichardson updated this revision to Diff 49606.Oct 25 2018, 11:21 AM
  • Fixed all issues found by universe build with WARNS=6
  • Silenced a false positive GCC warning
This revision now requires review to proceed.Oct 25 2018, 11:21 AM
Harbormaster completed remote builds in B20418: Diff 49606.Oct 25 2018, 11:21 AM
arichardson edited the summary of this revision. (Show Details)Oct 25 2018, 11:21 AM
kib added a comment.Oct 25 2018, 11:49 AM

Please commit whatever you have now. phab makes it impossible to cleanly see the diff between your patches when there are additional changes in the code from upstream repo, I do not want to re-read all the changes one more time.

brooks accepted this revision.Oct 29 2018, 8:50 PM
This revision is now accepted and ready to land.Oct 29 2018, 8:50 PM
Closed by commit rS339879: rtld-elf: fix more warnings to allow compiling with WARNS=6 (authored by arichardson). · Explain WhyOct 29 2018, 9:08 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 29 2018, 9:08 PM

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
2 lines
2 lines
15 lines
2 lines

Diff 48004

View Options

libexec/rtld-elf/libmap.c

Loading...
View Options

libexec/rtld-elf/malloc.c

Loading...
View Options

libexec/rtld-elf/rtld.c

Loading...
View Options

libexec/rtld-elf/rtld_lock.c

Loading...