Page MenuHomeFreeBSD

Remove vm_page_remque().
ClosedPublic

Authored by markj on Sep 4 2018, 8:03 PM.
Tags
None
Referenced Files
F152677360: D17025.id47658.diff
Thu, Apr 16, 11:25 AM
Unknown Object (File)
Wed, Apr 15, 1:46 PM
Unknown Object (File)
Tue, Apr 14, 5:35 PM
Unknown Object (File)
Tue, Apr 14, 4:38 PM
Unknown Object (File)
Fri, Apr 10, 7:58 PM
Unknown Object (File)
Mon, Apr 6, 5:39 PM
Unknown Object (File)
Sat, Apr 4, 10:00 PM
Unknown Object (File)
Wed, Apr 1, 11:51 AM
Subscribers

Details

Summary

See r338276. It is not sufficient to return immediately if
m->queue == PQ_NONE since another thread may be update the page's
queue state concurrently. vm_page_dequeue() now just returns if the
page is not enqueued (prior to r332974 it would panic in this case), so
simply replace all vm_page_remque() calls with vm_page_dequeue()
calls.

Test Plan

The problem was found while reading code. Peter is testing
this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable