Page MenuHomeFreeBSD
Differential D16832

New port: devel/vcglib: library for manipulation, processing, cleaning, simplifying triangle meshes
ClosedPublic
Actions

Authored by fernape on Aug 21 2018, 5:33 PM.
Tags
None
Referenced Files
F173783712: D16832.id47128.diff
Mon, Sep 28, 9:29 AM
F173777115: D16832.id47053.diff
Mon, Sep 28, 8:10 AM
F173773622: D16832.id47537.diff
Mon, Sep 28, 7:32 AM
F173769541: D16832.id.diff
Mon, Sep 28, 6:43 AM
F173700674: D16832.id47541.diff
Sun, Sep 27, 7:59 PM
Unknown Object (File)
Sun, Sep 27, 12:39 PM
Unknown Object (File)
Sun, Sep 27, 6:04 AM
Unknown Object (File)
Sun, Sep 27, 3:38 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
tz
Summary

The Visualization and Computer Graphics Library (VCGlib for short) is a open
source, portable, C++, templated, no dependency, library for manipulation,
processing, cleaning, simplifying triangle meshes.

It is needed for newer versions of cad/meshlab

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 11.2amd64, 12i386 OK
  • make index OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 19327
Build 18932: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 21 2018, 5:33 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 21 2018, 5:33 PM
Harbormaster completed remote builds in B19015: Diff 47053.Aug 21 2018, 5:33 PM
linimon retitled this revision from New port: devel/vcglib to New port: devel/vcglib: library for manipulation, processing, cleaning, simplifying triangle meshes.Aug 22 2018, 4:54 AM
mat added inline comments.Aug 22 2018, 6:50 AM
devel/vcglib/Makefile
22–24

Are you sure flattening the upstream hierarchy is right?

fernape updated this revision to Diff 47128.Aug 22 2018, 8:40 PM

Don't flatten hierarchy.

Reported by mat@

Harbormaster completed remote builds in B19067: Diff 47128.Aug 22 2018, 8:40 PM
fernape marked an inline comment as done.Aug 22 2018, 8:41 PM
fernape added inline comments.
devel/vcglib/Makefile
22–24

Most likely not. Thanks!

tcberner requested changes to this revision.Aug 31 2018, 10:56 AM

This is a new port. So you need to hook it up into the tree:

Take a look at devel/Makefile.

This revision now requires changes to proceed.Aug 31 2018, 10:56 AM
fernape updated this revision to Diff 47537.Aug 31 2018, 6:17 PM
fernape marked an inline comment as done.

Add missing entry in devel/Makefile

Harbormaster completed remote builds in B19327: Diff 47537.Aug 31 2018, 6:17 PM
tcberner added inline comments.Aug 31 2018, 7:33 PM
devel/vcglib/Makefile
21

^ any reason to keep those comments? :)

fernape updated this revision to Diff 47541.Aug 31 2018, 8:28 PM

Remove comments.

Harbormaster completed remote builds in B19329: Diff 47541.Aug 31 2018, 8:28 PM
fernape marked 2 inline comments as done.Aug 31 2018, 8:29 PM
fernape added inline comments.
devel/vcglib/Makefile
21

No :S

mat added inline comments.Sep 1 2018, 8:14 AM
devel/vcglib/Makefile
24

?

fernape updated this revision to Diff 47559.Sep 1 2018, 9:02 AM
fernape marked an inline comment as done.

Remove the very last piece of comments in the Makefile

Harbormaster completed remote builds in B19343: Diff 47559.Sep 1 2018, 9:02 AM
fernape marked 2 inline comments as done.Sep 9 2018, 3:28 PM
tcberner accepted this revision.Sep 21 2018, 3:55 AM
This revision is now accepted and ready to land.Sep 21 2018, 3:55 AM
fernape closed this revision.Sep 21 2018, 4:14 PM

Committed in r480283

Revision Contents
Changeset List

PathSize
devel/
1 line
27 lines
3 lines
10 lines
1178 lines

Diff 47537

View Options

devel/Makefile

Loading...
View Options

devel/vcglib/

Loading...
View Options

devel/vcglib/Makefile

Loading...
View Options

devel/vcglib/distinfo

Loading...
View Options

devel/vcglib/pkg-descr

Loading...
View Options

devel/vcglib/pkg-plist

Loading...