Page MenuHomeFreeBSD
Differential D16922

Add libxo(3) support to last(1).
ClosedPublic
Actions

Authored by philip on Aug 27 2018, 4:54 PM.
Tags
None
Referenced Files
F172889673: D16922.diff
Mon, Sep 21, 9:19 PM
F172886173: D16922.id47388.diff
Mon, Sep 21, 8:37 PM
F172882029: D16922.id47385.diff
Mon, Sep 21, 7:54 PM
F172881985: D16922.id47351.diff
Mon, Sep 21, 7:54 PM
F172881965: D16922.id47385.diff
Mon, Sep 21, 7:54 PM
Unknown Object (File)
Fri, Sep 18, 10:44 PM
Unknown Object (File)
Fri, Sep 18, 4:57 PM
Unknown Object (File)
Fri, Sep 18, 3:57 PM
View All Files
Subscribers
imp
kp

Details

Reviewers
kp
Group Reviewers
manpages
Commits
rS338352: Add libxo(3) support to last(1).
Summary

Adds libxo(3) support to last(1).

Test Plan
  • Diff confirms that output without --libxo is unchanged
  • Output with --libxo looks sane

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19239
Build 18852: arc lint + arc unit

Event Timeline

philip created this revision.Aug 27 2018, 4:54 PM
Harbormaster completed remote builds in B19217: Diff 47351.Aug 27 2018, 4:54 PM
kp accepted this revision.Aug 28 2018, 1:14 PM
kp added a subscriber: kp.
kp added inline comments.
usr.bin/last/last.c
121

I wonder if it's worth putting this in an atexit(3) callback. There are at least 4 calls to xo_finish() spread around the code, and it's easy to forget one, now or later if more are added.

This revision is now accepted and ready to land.Aug 28 2018, 1:14 PM
philip updated this revision to Diff 47385.Aug 28 2018, 4:34 PM
  • last: use xo_finish_atexit wrapper
This revision now requires review to proceed.Aug 28 2018, 4:34 PM
Harbormaster completed remote builds in B19239: Diff 47385.Aug 28 2018, 4:34 PM
philip marked an inline comment as done.Aug 28 2018, 4:35 PM
kp accepted this revision.Aug 28 2018, 4:42 PM
This revision is now accepted and ready to land.Aug 28 2018, 4:42 PM
Closed by commit rS338352: Add libxo(3) support to last(1). (authored by philip). · Explain WhyAug 28 2018, 5:10 PM
This revision was automatically updated to reflect the committed changes.
Herald added a reviewer: manpages. · View Herald TranscriptAug 28 2018, 5:10 PM
Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

PathSize
usr.bin/
last/
1 line
16 lines
79 lines

Diff 47385

View Options

usr.bin/last/Makefile

Loading...
View Options

usr.bin/last/last.1

Loading...
View Options

usr.bin/last/last.c

Loading...