compiler-rt: add floatditf and floatunditf
ClosedPublic
Actions

Authored by emaste on Mar 30 2015, 1:48 PM.

Details

Reviewers

Commits

rS281223: compiler-rt: add floatditf and floatunditf

Summary

These are long integer (di_int/du_int) to quad precision floating point conversions.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

emaste retitled this revision from to compiler-rt: add floatditf and floatunditf.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: ed, dim, andrew.

ed added inline comments.Mar 30 2015, 1:57 PM

contrib/compiler-rt/lib/builtins/floatditf.c
12 ↗	(On Diff #4509)	Out of curiosity, is this also what this function is supposed to do unconditionally? These functions are not supposed to integrate with `fegetround()` / `FLT_ROUNDS`?
47 ↗	(On Diff #4509)	These functions do not support subnormal floating point numbers. Should this be implemented, or at least documented?

contrib/compiler-rt/lib/builtins/floatditf.c
12 ↗	(On Diff #4509)	Good question; this was inherited from the floatsitf function I started from. The thread I started on llvmdev is here: http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/084064.html
47 ↗	(On Diff #4509)	I'm missing something - how would you implement int to subnormal float conversion?