Page MenuHomeFreeBSD
Differential D16797

Provide set_constraint_handler_s(3) man page
ClosedPublic
Actions

Authored by yuripv on Aug 19 2018, 12:28 AM.
Tags
None
Referenced Files
F103524088: D16797.id46927.diff
Tue, Nov 26, 2:12 AM
Unknown Object (File)
Fri, Nov 22, 10:52 AM
Unknown Object (File)
Thu, Nov 7, 3:27 PM
Unknown Object (File)
Tue, Nov 5, 4:03 AM
Unknown Object (File)
Tue, Nov 5, 2:34 AM
Unknown Object (File)
Wed, Oct 30, 1:25 PM
Unknown Object (File)
Wed, Oct 30, 12:59 AM
Unknown Object (File)
Tue, Oct 29, 5:51 PM
View All 78 Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
manpages
Commits
rS338051: Provide set_constraint_handler_s(3) man page.
rS338049: Clarify that memset_s(3) requires __STDC_WANT_LIB_EXT1__ for visibility.
Summary

Provide set_constraint_handler_s(3) man page, with abort_handler_s(3) and ignore_handler_s(3) links, reference it in memset(3) (and fix some small issues there).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

yuripv created this revision.Aug 19 2018, 12:28 AM
Herald added a reviewer: manpages. · View Herald TranscriptAug 19 2018, 12:28 AM
Herald added a subscriber: imp. · View Herald Transcript
kib added inline comments.Aug 19 2018, 6:52 AM
lib/libc/stdlib/Makefile.inc
19

What is changed in this line ?

lib/libc/stdlib/set_constraint_handler_s.3
2

What is this, and where did you get the source of the man page ?

63

Move type definitions into the synopsis.

yuripv marked 2 inline comments as done.Aug 19 2018, 9:05 AM
yuripv added inline comments.
lib/libc/stdlib/Makefile.inc
19

Just changing the spaces to a tab as done elsewhere in this Makefile. Will revert if this looks *too* unrelated.

lib/libc/stdlib/set_constraint_handler_s.3
2

I did wrote it after reading everything I have found in the web on the topic and incorporating the illumos review. The name in the copyright is the company I'm working for.

63

Done.

yuripv updated this revision to Diff 46918.Aug 19 2018, 9:07 AM
yuripv marked 2 inline comments as done.

Move handler prototype to SYNOPSIS.

kib added inline comments.Aug 19 2018, 9:29 AM
lib/libc/stdlib/Makefile.inc
19

No problem, just that I will commit it separately.

lib/libc/stdlib/set_constraint_handler_s.3
2

Are you sure that assigning copyright to your employer is the correct thing to do ? Is the company aware of your activity, does it need to be aware ?

Even if assigning to company, it is useful to add a note about author, look for examples in the tree.

42

The type defs should have typedef somewhere ? Am I missing it ?

yuripv updated this revision to Diff 46922.Aug 19 2018, 1:27 PM
yuripv marked 2 inline comments as done.
yuripv added inline comments.
lib/libc/stdlib/set_constraint_handler_s.3
2

Doesn't matter much, changed the copyright line and added AUTHORS section.

42

Sorry, fixed.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2018, 2:25 PM
Closed by commit rS338049: Clarify that memset_s(3) requires __STDC_WANT_LIB_EXT1__ for visibility. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.
kib reopened this revision.Aug 19 2018, 2:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 19 2018, 2:40 PM
Closed by commit rS338051: Provide set_constraint_handler_s(3) man page. (authored by kib). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
libc/
stdlib/
9 lines
147 lines
string/
11 lines

Diff 46922

View Options

lib/libc/stdlib/Makefile.inc

Loading...
View Options

lib/libc/stdlib/set_constraint_handler_s.3

Loading...
View Options

lib/libc/string/memset.3

Loading...