Page MenuHomeFreeBSD
Differential D16588

Sanity check BIOS EDD CHS numbers before using them.
ClosedPublic
Actions

Authored by delphij on Aug 4 2018, 8:53 AM.
Tags
None
Referenced Files
F168309681: D16588.id46280.diff
Thu, Aug 27, 1:54 PM
Unknown Object (File)
Wed, Aug 26, 3:09 PM
Unknown Object (File)
Tue, Aug 25, 4:38 PM
Unknown Object (File)
Tue, Aug 25, 10:47 AM
Unknown Object (File)
Mon, Aug 24, 11:52 AM
Unknown Object (File)
Sun, Aug 23, 8:53 PM
Unknown Object (File)
Thu, Aug 20, 8:12 PM
Unknown Object (File)
Thu, Aug 20, 2:56 PM
View All Files
Subscribers
dhw
imp

Details

Reviewers
cy
tsoome
Summary

In r337271, we limited the sector number to the lower of calculated
number and CHS based number. However, on some systems, BIOS would
report 0 in CHS fields, making the system to think there is 0 sectors.

Add a check before comparing the calculated total with bd_sectors.

Test Plan

boot

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18577
Build 18272: arc lint + arc unit

Event Timeline

delphij created this revision.Aug 4 2018, 8:53 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2018, 8:53 AM
Harbormaster completed remote builds in B18577: Diff 46280.Aug 4 2018, 8:53 AM
tsoome accepted this revision.Aug 4 2018, 11:12 AM
This revision is now accepted and ready to land.Aug 4 2018, 11:12 AM
dhw added a subscriber: dhw.Aug 4 2018, 1:28 PM

The above change allowed a kernel to load on my laptop[[ https://wiki.freebsd.org/Laptops/Dell_Precision_M4800?highlight=(\bCategoryLaptop\b)| Dell Precision M4800 ]] after updating from r337232 -> r337285; without the change, the kernel was unloadable ("Can't load kernel") and I didn't even get a loader menu (e.g., to facilitate loading a different kernel).

cy accepted this revision.Aug 4 2018, 1:37 PM
delphij closed this revision.Aug 4 2018, 2:15 PM

Referenced wrong review. This was committed as rS337317.

Revision Contents
Changeset List

PathSize
stand/
i386/
libi386/
2 lines

Diff 46280

View Options

stand/i386/libi386/biosdisk.c

Loading...