Details
- Reviewers
tcberner tz - Commits
- rP476247: biology/bcftools: update to 1.9
- portlint -AC OK (see note below)
- poudriere builds for {10.4,11.1}{amd64,i386},11.2 amd64, 12i386 OK
- run test in 10.4 amd64 OK
During make, this error shows up:
find: /usr/home/fernape/FreeBSD-repos/ports/head/biology/bcftools/work/stage/usr/local/lib/perl5/site_perl: No such file or directory
This is present before the update.
Also, I added USE_LDCONFIG, but portlint complains with:
You have defined USE_LDCONFIG, but this port does not install any shared objects
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 18532 Build 18234: arc lint + arc unit
Event Timeline
Yes, I noticed that (also, we need to wait for maintainer timeout, due on August 12th).
About the other two things: USE_LDCONFIG warning seems a false positive. What about the perl thing? I can not trace the origin of the problem.
I think the maintainer set a "+" flag, so I assume it's fine ^^
As for the perl messages, checkout Mk/Uses/perl5.mk's fix-perl-things target:
[...] /usr/bin/find /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage -name '*.bs' -size 0 -delete || : /bin/rm -f /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/5.26/mach/perllocal.pod* || : /bin/rmdir -p /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/5.26/mach 2>/dev/null || : [ -d "/wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/site_perl/man/man3" ] && /usr/bin/find /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/site_perl/man/man3 -name '*::README.3' -delete || : /usr/bin/find /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/site_perl -name README.pod -delete || : find: /wrkdirs/poudriere/ports/reviews/biology/bcftools/work/stage/usr/local/lib/perl5/site_perl: No such file or directory [...]
Maintainer here. I approve updating this port as long as htslib, samtools, and bcftools are updated together.
biology/bcftools/Makefile | ||
---|---|---|
41–43 | That was my first attempt, but when reading INSTALL file, I had some doubts. It says that if we use gsl the resultant software MUST be GPL compatible, but it also says that the default building is dual MIT-GPL and that we can choose which one to use. I'm no expert in licenses but sounds a bit confusing to me. |
Update LICENSE handling.
The INSTALL file states that by default the software is dual licensed (MIT and
GPL) and we can choose (so we choose MIT by default). If using gsl, we can no
longer choose and we need to ship the resultant software with terms compatible
with GPL, so add GPLv3 to LICENSE and set LICENSE_COMB to multi.
biology/bcftools/Makefile | ||
---|---|---|
38–39 | ^ you could use USES=localbase |