Page MenuHomeFreeBSD
Differential D15095

HWPMC tracing support (8) -- pmctrace ARM Coresight
Needs ReviewPublic
Actions

Authored by br on Apr 16 2018, 1:33 PM.
Tags
None
Referenced Files
F115193814: D15095.id52225.diff
Mon, Apr 21, 7:54 AM
F115126955: D15095.id41520.diff
Sun, Apr 20, 5:36 PM
Unknown Object (File)
Sat, Apr 19, 8:31 PM
Unknown Object (File)
Sat, Apr 19, 8:27 PM
Unknown Object (File)
Sat, Apr 19, 8:18 PM
Unknown Object (File)
Sat, Apr 19, 7:59 PM
Unknown Object (File)
Sat, Apr 19, 7:43 PM
Unknown Object (File)
Sat, Apr 19, 7:40 PM
View All Files
Subscribers
None

Details

Reviewers
kib
markj

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br created this revision.Apr 16 2018, 1:33 PM
br added reviewers: emaste, markj.Apr 16 2018, 1:35 PM
br added a parent revision: D12875: HWPMC tracing support (1) -- main.
br updated this revision to Diff 42988.May 25 2018, 3:17 PM

Regenerate patch

br updated this revision to Diff 43138.May 30 2018, 1:25 PM

merge changes from upstream

br updated this revision to Diff 43248.Jun 1 2018, 5:03 PM

regenerate

br updated this revision to Diff 46204.Aug 2 2018, 6:02 PM
br removed a reviewer: emaste.

regenerate

br updated this revision to Diff 52225.Dec 21 2018, 1:20 PM

regenerate

br updated this revision to Diff 53066.Jan 21 2019, 6:02 PM

wrap lines that are longer than 79 characters

br retitled this revision from HWPMC tracing support (8) -- pmctrace Intel PT to HWPMC tracing support (8) -- pmctrace ARM Coresight.Jan 21 2019, 6:02 PM
br updated this revision to Diff 62997.Oct 7 2019, 4:17 PM

Regenerate patch.

Revision Contents
Changeset List

PathSize
usr.sbin/
pmctrace/
39 lines
535 lines

Diff 46204

View Options

usr.sbin/pmctrace/pmctrace_cs.h

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 LinesFBSD_1.0 {
fchdir; fchdir;
fchflags; fchflags;
fchmod; fchmod;
fchown; fchown;
fcntl; fcntl;
fhopen; fhopen;
flock; flock;
fork; fork;
fpathconf; fpathconf;
kibUnsubmitted
Done
Inline Actions

Add context to the diff. Even without the context, I am sure that you put the symbols into the wrong namespace.

kib: Add context to the diff. Even without the context, I am sure that you put the symbols into the…
jack_gandi.netAuthorUnsubmitted
Done
Inline Actions

Should I add a FBSD_1.6 section then?

jack_gandi.net: Should I add a FBSD_1.6 section then?
jack_gandi.netAuthorUnsubmitted
Done
Inline Actions

nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most recent namespace (FBSD_1.5)

jack_gandi.net: nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most…
fsync; fsync;
futimes; futimes;
getaudit; getaudit;
getaudit_addr; getaudit_addr;
getauid; getauid;
getcontext; getcontext;
getdtablesize; getdtablesize;
getegid; getegid;
▲ Show 20 Lines • Show All 285 Lines • ▼ Show 20 LinesFBSD_1.5 {
fdatasync; fdatasync;
fhstat; fhstat;
fhstatfs; fhstatfs;
fstat; fstat;
fstatat; fstatat;
fstatfs; fstatfs;
getdents; getdents;
getdirentries; getdirentries;
getfsstat; getfsstat;
kibUnsubmitted
Not Done
Inline Actions

No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6.

kib: No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6.
getrandom; getrandom;
kevent; kevent;
lstat; lstat;
mknod; mknod;
mknodat; mknodat;
stat; stat;
statfs; statfs;
cpuset_getdomain; cpuset_getdomain;
cpuset_setdomain; cpuset_setdomain;
}; };
FBSD_1.6 {
fhlink;
fhlinkat;
fhreadlink;
getfhat;
};
FBSDprivate_1.0 { FBSDprivate_1.0 {
___acl_aclcheck_fd; ___acl_aclcheck_fd;
__sys___acl_aclcheck_fd; __sys___acl_aclcheck_fd;
___acl_aclcheck_file; ___acl_aclcheck_file;
__sys___acl_aclcheck_file; __sys___acl_aclcheck_file;
___acl_aclcheck_link; ___acl_aclcheck_link;
__sys___acl_aclcheck_link; __sys___acl_aclcheck_link;
___acl_delete_fd; ___acl_delete_fd;
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 LinesFBSDprivate_1.0 {
__sys_fchown; __sys_fchown;
_fcntl; _fcntl;
__sys_fcntl; __sys_fcntl;
__fcntl_compat; __fcntl_compat;
_fhopen; _fhopen;
__sys_fhopen; __sys_fhopen;
_fhstat; _fhstat;
__sys_fhstat; __sys_fhstat;
_fhstatfs; _fhstatfs;
brooksUnsubmitted
Done
Inline Actions

I believe it's unnecessary to add these as there are no potential consumers of these symbols.

brooks: I believe it's unnecessary to add these as there are no potential consumers of these symbols.
__sys_fhstatfs; __sys_fhstatfs;
_flock; _flock;
__sys_flock; __sys_flock;
_fork; _fork;
__sys_fork; __sys_fork;
_fpathconf; _fpathconf;
__sys_fpathconf; __sys_fpathconf;
_fstat; _fstat;
▲ Show 20 Lines • Show All 443 Lines • Show Last 20 Lines
View Options

usr.sbin/pmctrace/pmctrace_cs.c

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 LinesFBSD_1.0 {
fchdir; fchdir;
fchflags; fchflags;
fchmod; fchmod;
fchown; fchown;
fcntl; fcntl;
fhopen; fhopen;
flock; flock;
fork; fork;
fpathconf; fpathconf;
kibUnsubmitted
Done
Inline Actions

Add context to the diff. Even without the context, I am sure that you put the symbols into the wrong namespace.

kib: Add context to the diff. Even without the context, I am sure that you put the symbols into the…
jack_gandi.netAuthorUnsubmitted
Done
Inline Actions

Should I add a FBSD_1.6 section then?

jack_gandi.net: Should I add a FBSD_1.6 section then?
jack_gandi.netAuthorUnsubmitted
Done
Inline Actions

nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most recent namespace (FBSD_1.5)

jack_gandi.net: nevermind, I just realized https://wiki.freebsd.org/AddingSyscalls says to put them in the most…
fsync; fsync;
futimes; futimes;
getaudit; getaudit;
getaudit_addr; getaudit_addr;
getauid; getauid;
getcontext; getcontext;
getdtablesize; getdtablesize;
getegid; getegid;
▲ Show 20 Lines • Show All 285 Lines • ▼ Show 20 LinesFBSD_1.5 {
fdatasync; fdatasync;
fhstat; fhstat;
fhstatfs; fhstatfs;
fstat; fstat;
fstatat; fstatat;
fstatfs; fstatfs;
getdents; getdents;
getdirentries; getdirentries;
getfsstat; getfsstat;
kibUnsubmitted
Not Done
Inline Actions

No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6.

kib: No, FBSD_1.5 is wrong again. New 13-CURRENT symbols must go into FBSD_1.6.
getrandom; getrandom;
kevent; kevent;
lstat; lstat;
mknod; mknod;
mknodat; mknodat;
stat; stat;
statfs; statfs;
cpuset_getdomain; cpuset_getdomain;
cpuset_setdomain; cpuset_setdomain;
}; };
FBSD_1.6 {
fhlink;
fhlinkat;
fhreadlink;
getfhat;
};
FBSDprivate_1.0 { FBSDprivate_1.0 {
___acl_aclcheck_fd; ___acl_aclcheck_fd;
__sys___acl_aclcheck_fd; __sys___acl_aclcheck_fd;
___acl_aclcheck_file; ___acl_aclcheck_file;
__sys___acl_aclcheck_file; __sys___acl_aclcheck_file;
___acl_aclcheck_link; ___acl_aclcheck_link;
__sys___acl_aclcheck_link; __sys___acl_aclcheck_link;
___acl_delete_fd; ___acl_delete_fd;
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 LinesFBSDprivate_1.0 {
__sys_fchown; __sys_fchown;
_fcntl; _fcntl;
__sys_fcntl; __sys_fcntl;
__fcntl_compat; __fcntl_compat;
_fhopen; _fhopen;
__sys_fhopen; __sys_fhopen;
_fhstat; _fhstat;
__sys_fhstat; __sys_fhstat;
_fhstatfs; _fhstatfs;
brooksUnsubmitted
Done
Inline Actions

I believe it's unnecessary to add these as there are no potential consumers of these symbols.

brooks: I believe it's unnecessary to add these as there are no potential consumers of these symbols.
__sys_fhstatfs; __sys_fhstatfs;
_flock; _flock;
__sys_flock; __sys_flock;
_fork; _fork;
__sys_fork; __sys_fork;
_fpathconf; _fpathconf;
__sys_fpathconf; __sys_fpathconf;
_fstat; _fstat;
▲ Show 20 Lines • Show All 443 Lines • Show Last 20 Lines