Page MenuHomeFreeBSD

snd_hda: Enable bus_dmamap_sync operations, both new and uncommented
ClosedPublic

Authored by jhibbits on Jul 30 2018, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 9:21 PM
Unknown Object (File)
Mon, Nov 18, 6:08 PM
Unknown Object (File)
Mon, Nov 4, 8:02 PM
Unknown Object (File)
Oct 19 2024, 4:54 PM
Unknown Object (File)
Oct 17 2024, 4:20 PM
Unknown Object (File)
Oct 17 2024, 4:12 PM
Unknown Object (File)
Oct 15 2024, 5:42 PM
Unknown Object (File)
Oct 3 2024, 12:39 AM
Subscribers

Details

Summary

Make sure both sides of the memory accesses in snd_hda (device and CPU)
can see coherent memory. This is needed on weakly ordered architectures
including PowerPC and ARM. Patch originally by mmel, with small changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18443
Build 18150: arc lint + arc unit

Event Timeline

The commit message is a bit misleading. This patch ensures DMA coherency only for control structures but audio data buffers are not covered by required bus_dmamap_sync() operations. (We simply don't have right sync operation for syncing in progress DMA buffers - something like make buffer range snapshot before CPU read and make buffer range snapshot after CPU write).
Can you, please, elaborate this fact in commit message.

Otherwise, LGTM.

This revision is now accepted and ready to land.Aug 1 2018, 8:40 AM
This revision was automatically updated to reflect the committed changes.