Page MenuHomeFreeBSD
Differential D2204

Add a DFLAGS variable for dtrace(1).
ClosedPublic
Actions

Authored by markj on Apr 1 2015, 10:57 PM.
Tags
None
Referenced Files
F168312353: D2204.id4735.diff
Thu, Aug 27, 2:11 PM
F168312281: D2204.id4588.diff
Thu, Aug 27, 2:11 PM
F168308344: D2204.diff
Thu, Aug 27, 1:46 PM
Unknown Object (File)
Fri, Aug 21, 4:08 AM
Unknown Object (File)
Tue, Aug 11, 7:56 PM
Unknown Object (File)
Fri, Aug 7, 8:38 AM
Unknown Object (File)
Tue, Aug 4, 7:25 AM
Unknown Object (File)
Tue, Aug 4, 5:20 AM
View All Files
Subscribers
bdrewery
imp

Details

Reviewers
rpaulo
imp
Group Reviewers
DTrace
Commits
rS281258: Add a DTRACEFLAGS variable, which can be used to pass additional variables
Summary

This change adds DFLAGS to sys.mk. It can be overridden by programs
or libraries that wish to compile USDT probes with lazyload mode.

This change also adds -C to the default dtrace(1) flags. This causes
dtrace(1) to run the C preprocessor on D scripts; one can also add
-D to DFLAGS to set preprocessor variables.

While in the neighbourhood, correctly sort definitions for CP, CPP and
DTRACE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

markj updated this revision to Diff 4588.Apr 1 2015, 10:57 PM
markj retitled this revision from to Add a DFLAGS variable for dtrace(1)..
markj edited the test plan for this revision. (Show Details)
markj updated this object.
Herald added subscribers: imp, bdrewery. · View Herald TranscriptApr 1 2015, 10:57 PM
imp accepted this revision.Apr 1 2015, 11:00 PM
imp added a reviewer: imp.

This is fine, but makes the name space pollution for strict POSIX mode a little worse than it is today.

share/mk/sys.mk
65–70

These don't belong in the POSIX section. But we've kinda fallen off the POSIX bandwagon in other places.

This revision is now accepted and ready to land.Apr 1 2015, 11:00 PM
markj added reviewers: rpaulo, DTrace.Apr 1 2015, 11:05 PM
markj added a comment.Apr 1 2015, 11:38 PM
In D2204#3, @imp wrote:

This is fine, but makes the name space pollution for strict POSIX mode a little worse than it is today.

I could wrap DTRACE and DFLAGS in a .if !defined(%POSIX), assuming that's what you're referring to by strict POSIX mode.

rpaulo accepted this revision.Apr 2 2015, 3:51 AM
rpaulo edited edge metadata.
markj updated this revision to Diff 4733.Apr 8 2015, 2:26 AM
markj edited edge metadata.
  • Use DTRACEFLAGS instead of DFLAGS.
This revision now requires review to proceed.Apr 8 2015, 2:26 AM
markj closed this revision.Apr 8 2015, 2:51 AM
markj updated this revision to Diff 4735.

Closed by commit rS281258 (authored by @markj).

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines
14 lines

Diff 4588

View Options

share/mk/bsd.dep.mk

Loading...
View Options

share/mk/sys.mk

Loading...