Page MenuHomeFreeBSD

Add a DFLAGS variable for dtrace(1).
ClosedPublic

Authored by markj on Apr 1 2015, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 7:38 PM
Unknown Object (File)
Nov 16 2024, 7:07 PM
Unknown Object (File)
Oct 30 2024, 7:59 PM
Unknown Object (File)
Oct 26 2024, 2:00 AM
Unknown Object (File)
Oct 26 2024, 2:00 AM
Unknown Object (File)
Oct 26 2024, 2:00 AM
Unknown Object (File)
Oct 26 2024, 1:50 AM
Unknown Object (File)
Oct 25 2024, 8:40 AM
Subscribers

Details

Summary

This change adds DFLAGS to sys.mk. It can be overridden by programs
or libraries that wish to compile USDT probes with lazyload mode.

This change also adds -C to the default dtrace(1) flags. This causes
dtrace(1) to run the C preprocessor on D scripts; one can also add
-D to DFLAGS to set preprocessor variables.

While in the neighbourhood, correctly sort definitions for CP, CPP and
DTRACE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

markj retitled this revision from to Add a DFLAGS variable for dtrace(1)..
markj edited the test plan for this revision. (Show Details)
markj updated this object.
imp added a reviewer: imp.

This is fine, but makes the name space pollution for strict POSIX mode a little worse than it is today.

share/mk/sys.mk
65โ€“70 โ†—(On Diff #4588)

These don't belong in the POSIX section. But we've kinda fallen off the POSIX bandwagon in other places.

This revision is now accepted and ready to land.Apr 1 2015, 11:00 PM
In D2204#3, @imp wrote:

This is fine, but makes the name space pollution for strict POSIX mode a little worse than it is today.

I could wrap DTRACE and DFLAGS in a .if !defined(%POSIX), assuming that's what you're referring to by strict POSIX mode.

rpaulo edited edge metadata.
markj edited edge metadata.
  • Use DTRACEFLAGS instead of DFLAGS.
This revision now requires review to proceed.Apr 8 2015, 2:26 AM
markj updated this revision to Diff 4735.

Closed by commit rS281258 (authored by @markj).