Introduce test-program for auditpipe(4)
ClosedPublic
Actions

Authored by aniketp on Jul 22 2018, 4:31 PM.

Details

Reviewers

asomers

Commits

rS339094: MFC r336728:
rS336728: Introduce test program for auditpipe(4)

Summary

This revision introduces test-program for auditpipe(4). The tests currently only test initial
ioctls provided by auditpipe(4) and lay a foundation on how the tests will be organised later on.

The ioctls currently tested are:

AUDITPIPE_GET_QLEN
AUDITPIPE_GET_QLIMIT
AUDITPIPE_SET_QLIMIT
AUDITPIPE_GET_QLIMIT_MAX
AUDITPIPE_GET_QLIMIT_MIN
AUDITPIPE_GET_MAXAUDITDATA

Test Plan

Execute make && make install from test/sys/auditpipe.
Execute kyua test from /usr/tests/sys/auditpipe. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18253
Build 17981: arc lint + arc unit

Event Timeline

aniketp created this revision.Jul 22 2018, 4:31 PM

Harbormaster completed remote builds in B18252: Diff 45692.Jul 22 2018, 4:31 PM

asomers requested changes to this revision.Jul 22 2018, 5:16 PM

asomers added inline comments.

tests/sys/auditpipe/auditpipe_test.c
91	Why do you think it's probably 128? How about setting it to `curr_qlimit - 1` instead of hardcoding 128?
100	This should go in a cleanup step, not in the test body.