Makefile
ClosedPublic
Actions

Authored by arichardson on Jul 8 2018, 10:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 5, 10:05 PM

	Unknown Object (File)
	Sat, Sep 5, 8:07 AM

	Unknown Object (File)
	Sat, Sep 5, 3:21 AM

	Unknown Object (File)
	Fri, Sep 4, 10:11 AM

	Unknown Object (File)
	Thu, Sep 3, 12:23 PM

	Unknown Object (File)
	Thu, Sep 3, 5:08 AM

	Unknown Object (File)
	Thu, Sep 3, 3:55 AM

	Unknown Object (File)
	Wed, Sep 2, 6:26 AM

View All Files

Subscribers

imp

Details

Reviewers

brooks
bdrewery
kevans

Commits

rS336335: No longer install sys/nv.h and sys/cnv.h in lib/libnv/Makefile

Summary

Use tools/build/Makefile to install the headers into ${WORLDTMP}/legacy
instead. Compared to r336026 this has the minor advantage that it avoids
unncessary header installation when building the non-bootstrap libnv.

Test Plan

Host tools still build

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17921
Build 17678: arc lint + arc unit

Event Timeline

arichardson created this revision.Jul 8 2018, 10:08 PM

Harbormaster completed remote builds in B17921: Diff 45038.Jul 8 2018, 10:08 PM

A-ha! \0/ This is the solution I was searching for.

This revision is now accepted and ready to land.Jul 8 2018, 10:41 PM

@imp usually likes to see changes here.

tools/build/Makefile
52–54	The pattern above has been to use .PATH: ${SRCTOP}/sys/sys and then use SYSINCS+= nv.h and cnv.h. But if this works then fine.

LGTM

Closed by commit rS336335: No longer install sys/nv.h and sys/cnv.h in lib/libnv/Makefile (authored by arichardson). · Explain WhyJul 16 2018, 10:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

libnv/

Makefile

3 lines

tools/

build/

Makefile

3 lines

Diff 45038

View Options

lib/libnv/Makefile