Page MenuHomeFreeBSD
Differential D16130

Correct an obscure PV entry leak in the recent change to amd64's pmap_enter()
ClosedPublic
Actions

Authored by alc on Jul 4 2018, 7:07 PM.
Tags
None
Referenced Files
F140065367: D16130.id44884.diff
Fri, Dec 19, 6:37 PM
Unknown Object (File)
Sat, Dec 13, 11:47 AM
Unknown Object (File)
Fri, Nov 28, 8:33 AM
Unknown Object (File)
Thu, Nov 20, 9:51 PM
Unknown Object (File)
Thu, Nov 20, 9:43 PM
Unknown Object (File)
Thu, Nov 20, 9:43 PM
Unknown Object (File)
Thu, Nov 20, 9:36 PM
Unknown Object (File)
Nov 12 2025, 4:43 AM
View All 68 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rS335971: As of r335784, if pmap_enter() replaces a managed mapping by an unmanaged
Summary

Hypothetically, pmap_enter() could replace a managed mapping by an unmanaged mapping, in which case, pmap_enter() would currently leak the unlinked PV entry. This change frees that PV entry when the new mapping is unmanaged.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Jul 4 2018, 7:07 PM
markj accepted this revision.Jul 4 2018, 7:30 PM

I noticed this bug while reading the i386 pmap code. :)

This revision is now accepted and ready to land.Jul 4 2018, 7:30 PM
kib accepted this revision.Jul 4 2018, 8:05 PM
Closed by commit rS335971: As of r335784, if pmap_enter() replaces a managed mapping by an unmanaged (authored by alc). · Explain WhyJul 5 2018, 2:04 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 5 2018, 2:04 AM
alc added a comment.Jul 5 2018, 2:15 AM
In D16130#342002, @markj wrote:

I noticed this bug while reading the i386 pmap code. :)

I'm working on the i386 version. As you may have noticed, the i386 pmap has the CoW problem, but not the PV entry allocation problem.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines

Diff 44884

View Options

head/sys/amd64/amd64/pmap.c

Loading...