Differential D16100

Raise a proper SIGTRAP / TRAP_TRACE signal for a PT_STEP step on arm.
ClosedPublic
Actions

Authored by jhb on Jul 2 2018, 5:44 PM.

Tags

None

Referenced Files

	F133473449: D16100.id45844.diff
	Sun, Oct 26, 1:28 AM

	Unknown Object (File)
	Sat, Oct 25, 1:25 PM

	Unknown Object (File)
	Wed, Oct 22, 8:02 PM

	Unknown Object (File)
	Wed, Oct 22, 8:02 PM

	Unknown Object (File)
	Wed, Oct 22, 8:02 PM

	Unknown Object (File)
	Wed, Oct 22, 9:47 AM

	Unknown Object (File)
	Wed, Oct 8, 1:04 AM

	Unknown Object (File)
	Mon, Sep 29, 4:20 AM

View All 83 Files

Subscribers

Details

Reviewers

cognet
manu
imp

Group Reviewers

Commits

rS336722: Raise a proper SIGTRAP / TRAP_TRACE signal for a PT_STEP step on arm.

Summary

Previously, a step by PT_STEP resulted in no signal being raised to
the debugger so that a step was silently completed with the program
continuing to execute after the step. Fix by raising a SIGTRAP
signal with TRAP_TRACE as the signal code.

To simplify the error handling cases (if ptrace_clear_single_step()
fails, etc.) move the handling of PTRACE_BREAKPOINT into the
gdb_trapper() function. If ptrace_clear_single_step() fails,
gdb_trapper() won't claim the fault, and the default case of
SIGILL / ILL_OPC will be used.

Test Plan

Run the ptrace_test kyua tests on arm. Previously the tests using PT_STEP would fail, now all tests pass.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17793
Build 17571: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 2 2018, 5:44 PM

Herald added a subscriber: andrew. · View Herald TranscriptJul 2 2018, 5:44 PM

Harbormaster completed remote builds in B17793: Diff 44765.Jul 2 2018, 5:44 PM

jhb added a reviewer: ARM.Jul 2 2018, 6:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 25 2018, 6:11 PM

Closed by commit rS336722: Raise a proper SIGTRAP / TRAP_TRACE signal for a PT_STEP step on arm. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

43 lines

Diff 44765

sys/arm/arm/undefined.c

Loading...