Page MenuHomeFreeBSD

Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers
ClosedPublic

Authored by lakhanshiva_gmail.com on Jun 24 2018, 10:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 2:57 AM
Unknown Object (File)
Feb 8 2024, 1:48 PM
Unknown Object (File)
Jan 28 2024, 4:54 AM
Unknown Object (File)
Jan 28 2024, 4:34 AM
Unknown Object (File)
Jan 28 2024, 4:34 AM
Unknown Object (File)
Jan 27 2024, 6:25 AM
Unknown Object (File)
Jan 27 2024, 6:25 AM
Unknown Object (File)
Jan 27 2024, 6:25 AM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17761
Build 17550: arc lint + arc unit

Event Timeline

lakhanshiva_gmail.com retitled this revision from Summary: Add PNP info to PCI attachment of alc driver to Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.Jun 24 2018, 10:16 AM
lakhanshiva_gmail.com edited the summary of this revision. (Show Details)
chuck requested changes to this revision.Jun 24 2018, 1:16 PM
chuck added inline comments.
sys/dev/amdsmb/amdsmb.c
151

style nit, space between key word (if) and open parenthesis. Also needed on either side of comparator above (i.e. i < nitems(amdsmb_devs). Please fix here and check all other code modifications for this type of error.

sys/dev/bfe/if_bfe.c
160

Should this have a description? If so, please fix here and check other code changes for this type of issue.

sys/dev/ciss/ciss.c
207

Instead of moving this whole block below the ciss_vendor_data[] definitions, is it possible to only move the DRIVER_MODULE() and perhaps the MODULE_DEPEND() definitions to coincide with the new MODULE_PNP_INFO?

This revision now requires changes to proceed.Jun 24 2018, 1:16 PM

Please see https://reviews.freebsd.org/D15999 for a notion on how we might want to cut over the medium drivers to being table driven.

If I m not wrong this approach is specifically for the atheros drivers.
Isn't it ?

If I m not wrong this approach is specifically for the atheros drivers.
Isn't it ?

Why yes. Yes it is.

Or rather, it's inspired by it. And by the USB stuff, and by what Linux does. And it also takes a page from PC Card, where it's possible to have more complicated meta-data associated with the device than is otherwise allowed with the USB pattern.

  • Update PNP info to PCI attachment of amdsmb driver
  • Update PNP info to PCI attachments of bfe driver
  • Update PNP info to PCI attachment of ce driver
  • Update PNP info to PCI attachment of dpt driver
  • Update PNP info for PCI attachment of cp driver
  • Update PNP info to PCI attachments of ciss driver

Thanks for the comments chuck! Made the changes.

lakhanshiva_gmail.com edited the summary of this revision. (Show Details)
  • Update PNP info to PCI attachment of amdsmb driver
lakhanshiva_gmail.com edited the summary of this revision. (Show Details)

Converted spaces to tabs (in probe functions)

sys/dev/dpt/dpt_pci.c
84

This line still appears to uses spaces

lakhanshiva_gmail.com added inline comments.
sys/dev/dpt/dpt_pci.c
84

Converted them to tabs

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2018, 8:40 PM
This revision was automatically updated to reflect the committed changes.