Details

Reviewers

imp
chuck

Commits

rS336106: Add PNP info to PCI attachments of ciss driver
rS336105: Add PNP info to PCI attachment of dc driver
rS336104: Add PNP info to PCI attachments of bge driver
rS336103: Add PNP info to PCI attachments of bfe driver

Summary

Update PNP info to PCI attachments of amdsmb driver

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17588
Build 17401: arc lint + arc unit

Event Timeline

lakhanshiva_gmail.com created this revision.Jun 24 2018, 10:14 AM

Harbormaster completed remote builds in B17588: Diff 44383.Jun 24 2018, 10:14 AM

lakhanshiva_gmail.com retitled this revision from Summary: Add PNP info to PCI attachment of alc driver to Add PNP info to PCI attachment of alc, amdsmb, bfe, bge, ce, dpt, dc, ciss, cp drivers.Jun 24 2018, 10:16 AM

lakhanshiva_gmail.com edited the summary of this revision. (Show Details)

chuck requested changes to this revision.Jun 24 2018, 1:16 PM

chuck added inline comments.

sys/dev/amdsmb/amdsmb.c
151	style nit, space between key word (`if`) and open parenthesis. Also needed on either side of comparator above (i.e. `i < nitems(amdsmb_devs)`. Please fix here and check all other code modifications for this type of error.
sys/dev/bfe/if_bfe.c
160	Should this have a description? If so, please fix here and check other code changes for this type of issue.
sys/dev/ciss/ciss.c
207	Instead of moving this whole block below the `ciss_vendor_data[]` definitions, is it possible to only move the `DRIVER_MODULE()` and perhaps the `MODULE_DEPEND()` definitions to coincide with the new `MODULE_PNP_INFO`?

This revision now requires changes to proceed.Jun 24 2018, 1:16 PM

Thanks Chuck, I will make the changes.

Please see https://reviews.freebsd.org/D15999 for a notion on how we might want to cut over the medium drivers to being table driven.

If I m not wrong this approach is specifically for the atheros drivers.
Isn't it ?

In D15995#338704, @lakhanshiva_gmail.com wrote:

If I m not wrong this approach is specifically for the atheros drivers.
Isn't it ?

Why yes. Yes it is.

Or rather, it's inspired by it. And by the USB stuff, and by what Linux does. And it also takes a page from PC Card, where it's possible to have more complicated meta-data associated with the device than is otherwise allowed with the USB pattern.