audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2)
ClosedPublic
Actions

Authored by aniketp on Jun 27 2018, 11:30 AM.

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335791: audit(4): add tests for setsid, wait4, wait6, and kill

Summary

This revision introduces atf-c(3) tests for verifying the proper auditability for
syscalls categorized within process-control audit class.
List of syscalls:

setsid(2)
wait4(2)
wait6(2)
kill(2)

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17672
Build 17477: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 27 2018, 11:30 AM

Harbormaster completed remote builds in B17658: Diff 44517.Jun 27 2018, 11:30 AM

asomers requested changes to this revision.Jun 27 2018, 3:37 PM

asomers added inline comments.

tests/sys/audit/process-control.c
986	This assumes too much about Kyua's execution model. You shouldn't assume that it's already a process group leader. For example, if you invoke the test as `sudo ./process-control setsid_failure`, then it will fail.

This revision now requires changes to proceed.Jun 27 2018, 3:37 PM

Call setsid() prematurely to intentionally fail the tests

Harbormaster completed remote builds in B17672: Diff 44536.Jun 27 2018, 4:56 PM

asomers requested changes to this revision.Jun 27 2018, 4:59 PM

asomers added inline comments.

tests/sys/audit/process-control.c
982	This should work. But I would prefer a comment that indicates that we're intentionally ignoring the output of the first `setsid` call, because we don't know whether we're already a session leader.