Expose ZFS quotas over nfs
Needs ReviewPublic
Actions

Authored by sef on Jun 18 2018, 6:30 PM.

Details

Reviewers

mav
cem

Commits

rS336017: This exposes ZFS user and group quotas via the normal

Summary

This allows NFS quotas to query ZFS quotas. Note that it only works with querying (quota administration still needs to be done via the normal methods on the servers). It also generalizes some of the quota support in the commands and libraries, so it's not checking only for ufs, so it should also work on any other filesystem that supports the VFS calls. Although obviously I've only tested it with ZFS.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sef created this revision.Jun 18 2018, 6:30 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptJun 18 2018, 6:30 PM

Is it possible to provide a switch to disable the SETQUOTA RPC? (Assuming I'm understanding correctly that no additional authentication is done before it's permitted; rpc.rquotad runs at root privilege so when it issues vfs_quotactl it would not fail because insufficient privilege).

By the way I think there should be a CLI tool that invokes SETQUOTA (Linux have a package called quota-tools) for completeness.

include/rpcsvc/rquota.x
9–10	Since this was moved to header and was already commented out, maybe just delete the whole ifndef lint block here?
lib/libutil/quotafile.c
136	qf is leaked here?
libexec/rpc.rquotad/rquotad.c
305	opoen: typo. Should be open.
307	Is the pointer value meaningful for a system administrator?

Is it possible to provide a switch to disable the SETQUOTA RPC?

I'm not sure what you mean by a switch there?

include/rpcsvc/rquota.x
9–10	I have no objection to that :).
lib/libutil/quotafile.c
136	Fixed, will be in next version I upload in a bit
libexec/rpc.rquotad/rquotad.c
307	It's for debug, so I consider it more meaningful for a developer. I print out the entire set of function arguments, so I included the pointer. That's about it.

Incorporate feedback from delphij.

In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

I'm not sure what you mean by a switch there?

Sorry, I meant a command line option to rpc.rquotad if it's not clear.

In D15886#336082, @delphij wrote:

In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

Sorry, I meant a command line option to rpc.rquotad if it's not clear.

I don't have any code in there right now that handles the SETQUOTA RPC, so I'm still confused. Want to discuss it in email?

cem resigned from this revision.Jun 18 2018, 8:09 PM

In D15886#336083, @sef wrote:

In D15886#336082, @delphij wrote:

In D15886#336048, @sef wrote:

Is it possible to provide a switch to disable the SETQUOTA RPC?

Sorry, I meant a command line option to rpc.rquotad if it's not clear.

I don't have any code in there right now that handles the SETQUOTA RPC, so I'm still confused. Want to discuss it in email?

Oh right, it was me who was confused (somehow I thought you have implemented the RPC already, but it's only in the kernel for ZFS). LGTM now.

damian_damianek.be added a subscriber: damian_damianek.be.Jul 3 2018, 6:21 AM

Looks good to me.

This revision is now accepted and ready to land.Jul 3 2018, 7:52 PM

Closed by commit rS336017: This exposes ZFS user and group quotas via the normal (authored by sef). · Explain WhyJul 5 2018, 10:56 PM

This revision was automatically updated to reflect the committed changes.

Hey Guys, it's possible that this could have caused a regression with quota on NFS. Please take a look at: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239552