Introduce test-program for administrative system calls
ClosedPublic
Actions

Authored by aniketp on Jun 17 2018, 1:08 AM.

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335285: audit(4): Add tests for a few syscalls in the ad class

Summary

This revision introduces a test-program for syscalls in administrative audit class.
The system calls introduced are:

settimeofday(2)
adjtime(2)
getfh(2) nfs_getfh(2)

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17364
Build 17197: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 17 2018, 1:08 AM

Harbormaster completed remote builds in B17363: Diff 43929.Jun 17 2018, 1:08 AM

Update the Makefile

Harbormaster completed remote builds in B17364: Diff 43930.Jun 17 2018, 1:10 AM

For me the adjtime_failure call caused a kernel panic.

panic: Bad tailq NEXT(0xfffff80055d3d388->tqh_last) != NULL
cpuid = 3
time = 1529205824
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00264488a0
vpanic() at vpanic+0x1a3/frame 0xfffffe0026448900
panic() at panic+0x43/frame 0xfffffe0026448960
kaudit_to_bsm() at kaudit_to_bsm+0x5265/frame 0xfffffe0026448a10
audit_worker() at audit_worker+0x30d/frame 0xfffffe0026448a70
fork_exit() at fork_exit+0x84/frame 0xfffffe0026448ab0
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0026448ab0

@asomers It was passing for me.

Just to be sure, I set flag: all in /etc/security/audit_control but even then it passed without any issue

In D15861#335382, @aniketp wrote:

@asomers It was passing for me.

Just to be sure, I set flag: all in /etc/security/audit_control but even then it passed without any issue

Passing in 12.0-CURRENT or 11.1? What is uname -a?

Nevermind. I forgot that I had locally reverted r334296.

This revision is now accepted and ready to land.Jun 17 2018, 4:17 PM

Closed by commit rS335285: audit(4): Add tests for a few syscalls in the ad class (authored by asomers). · Explain WhyJun 17 2018, 4:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 17 2018, 4:25 PM