Page MenuHomeFreeBSD

Introduce test-program for network socket system calls
ClosedPublic

Authored by aniketp on Jun 14 2018, 2:41 PM.
Tags
None
Referenced Files
F132659818: D15803.id43825.diff
Sat, Oct 18, 8:22 PM
F132659814: D15803.id43755.diff
Sat, Oct 18, 8:22 PM
F132659809: D15803.id43760.diff
Sat, Oct 18, 8:22 PM
F132659808: D15803.id43756.diff
Sat, Oct 18, 8:22 PM
F132656788: D15803.id43756.diff
Sat, Oct 18, 7:46 PM
F132610802: D15803.id43828.diff
Sat, Oct 18, 10:05 AM
F132610779: D15803.id.diff
Sat, Oct 18, 10:04 AM
F132610778: D15803.id43761.diff
Sat, Oct 18, 10:04 AM
Subscribers

Details

Summary

This revision introduces a new test program network which deals with
auditing any syscall responsible for managing network communcations (as the name suggests)
System calls introduced are:

  • socket(2)
  • socketpair(2)
  • setsockopt(2)
Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17303
Build 17138: arc lint + arc unit

Event Timeline

Correct Makefile:

ATF_TESTS_C= file-attribute-modify   -> ATF_TESTS_C+= file-attribute-modify

Add the network source file which was accidentally missed in previous revision

tests/sys/audit/network.c
94

Does the "-1" in the audit record refer to the domain argument or to the return value? Either way, printing it as an unsigned number is a bug.

117

What does the 0x0 mean?

Update the tests with regards to above comments

This revision is now accepted and ready to land.Jun 15 2018, 4:39 PM
This revision was automatically updated to reflect the committed changes.