Details

Reviewers

asomers
rwatson
gnn

Commits

rS335215: audit(4): Add a few tests for network-related syscalls

Summary

This revision introduces a new test program network which deals with
auditing any syscall responsible for managing network communcations (as the name suggests)
System calls introduced are:

socket(2)
socketpair(2)
setsockopt(2)

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17303
Build 17138: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 14 2018, 2:41 PM

Harbormaster completed remote builds in B17261: Diff 43755.Jun 14 2018, 2:41 PM

Correct Makefile:

ATF_TESTS_C= file-attribute-modify   -> ATF_TESTS_C+= file-attribute-modify

Harbormaster completed remote builds in B17262: Diff 43756.Jun 14 2018, 2:52 PM

Rebase after rS335145

Harbormaster completed remote builds in B17265: Diff 43760.Jun 14 2018, 3:20 PM

Add the network source file which was accidentally missed in previous revision

Harbormaster completed remote builds in B17266: Diff 43761.Jun 14 2018, 3:22 PM

asomers added inline comments.Jun 15 2018, 2:43 PM

tests/sys/audit/network.c
94	Does the "-1" in the audit record refer to the domain argument or to the return value? Either way, printing it as an unsigned number is a bug.
117	What does the 0x0 mean?