Check for a 'pci' prefix rather than a full match in get_addr_props
ClosedPublic
Actions

Authored by jhibbits on Jun 15 2018, 3:45 AM.

Details

Reviewers

nwhitehorn
• ian
breno.leitao_gmail.com

Commits

rS335226: Check for a 'pci' prefix rather than a full match in get_addr_props

Summary

Newer OPAL device trees, such as those on POWER9 systems, use 'pciex' for
device_type, not 'pci'. Rather than enumerating all possible variants, just
check for a 'pci' prefix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17291
Build 17128: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jun 15 2018, 3:45 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 15 2018, 3:45 AM

Harbormaster completed remote builds in B17291: Diff 43796.Jun 15 2018, 3:45 AM

It's mildly stupid, since the universe of pci* isn't big, but I think I would prefer a check for "pci" || "pciex" to just checking the first three characters.

Change to nwhitehorn's preference. Either is fine with me.

Harbormaster completed remote builds in B17300: Diff 43813.Jun 15 2018, 2:15 PM

Don't you want strcmp() == 0?

I should probably caffeinate before making such trivial changes.

Harbormaster completed remote builds in B17309: Diff 43837.Jun 15 2018, 6:28 PM

nwhitehorn accepted this revision.Jun 15 2018, 6:33 PM

This revision is now accepted and ready to land.Jun 15 2018, 6:33 PM

breno.leitao_gmail.com accepted this revision.Jun 15 2018, 6:41 PM

Closed by commit rS335226: Check for a 'pci' prefix rather than a full match in get_addr_props (authored by jhibbits). · Explain WhyJun 15 2018, 6:55 PM

This revision was automatically updated to reflect the committed changes.