Page MenuHomeFreeBSD

Fix build of liquidio with base gcc on i386
ClosedPublic

Authored by dim on Jun 11 2018, 8:49 AM.
Tags
None
Referenced Files
F136994293: D15754.id43697.diff
Thu, Nov 20, 10:50 PM
F136994279: D15754.id.diff
Thu, Nov 20, 10:49 PM
F136994078: D15754.id43587.diff
Thu, Nov 20, 10:49 PM
F136991953: D15754.diff
Thu, Nov 20, 10:42 PM
Unknown Object (File)
Wed, Nov 12, 6:07 AM
Unknown Object (File)
Thu, Nov 6, 12:03 AM
Unknown Object (File)
Sun, Nov 2, 11:28 AM
Unknown Object (File)
Thu, Oct 30, 3:45 AM
Subscribers

Details

Summary

Base gcc fails to compile sys/dev/liquidio/lio_main.c for i386, with
the following -Werror warnings:

cc1: warnings being treated as errors
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c: In function 'lio_setup_glists':
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c:1774: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c:1775: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is because on i386, the casts from uint64_t to a pointer reduce
the values from 64 bit to 32 bit, and vice versa.

For gcc, this can be fixed by intermediate casts to uintptr_t. Note
that I am assuming the incoming values will always fit into 32 bit!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable