Page MenuHomeFreeBSD

Fix build of liquidio with base gcc on i386
ClosedPublic

Authored by dim on Jun 11 2018, 8:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 17 2024, 7:49 AM
Unknown Object (File)
Nov 5 2024, 4:14 AM
Unknown Object (File)
Oct 2 2024, 3:13 AM
Unknown Object (File)
Sep 18 2024, 7:18 AM
Unknown Object (File)
Sep 5 2024, 8:33 PM
Unknown Object (File)
Aug 31 2024, 12:26 AM
Unknown Object (File)
Aug 22 2024, 6:27 PM
Unknown Object (File)
Aug 17 2024, 9:04 PM
Subscribers

Details

Summary

Base gcc fails to compile sys/dev/liquidio/lio_main.c for i386, with
the following -Werror warnings:

cc1: warnings being treated as errors
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c: In function 'lio_setup_glists':
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c:1774: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
/usr/src/sys/modules/lio/../../dev/liquidio/lio_main.c:1775: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

This is because on i386, the casts from uint64_t to a pointer reduce
the values from 64 bit to 32 bit, and vice versa.

For gcc, this can be fixed by intermediate casts to uintptr_t. Note
that I am assuming the incoming values will always fit into 32 bit!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17164
Build 17016: arc lint + arc unit