Fix build of atk0110 with base gcc on i386
ClosedPublic
Actions

Authored by dim on Jun 9 2018, 9:07 PM.

Details

Reviewers

avg
emaste
jkim

Commits

rS335471: MFC r335296:
rS335296: Fix build of aibs with base gcc on i386

Summary

Base gcc fails to compile sys/dev/acpi_support/atk0110.c for i386,
with the following -Werror warnings:

cc1: warnings being treated as errors
/usr/src/sys/dev/acpi_support/atk0110.c: In function 'aibs_sysctl':
/usr/src/sys/dev/acpi_support/atk0110.c:456: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
/usr/src/sys/dev/acpi_support/atk0110.c: In function 'aibs_sysctl_ggrp':
/usr/src/sys/dev/acpi_support/atk0110.c:522: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
*** [atk0110.o] Error code 1

This is because on i386, the casts from SYSCTL_HANDLER_ARGS's arg2
(which is an intmax_t) to a pointer reduces the value from 64 bit to
32 bit.

For gcc, this can be fixed by an intermediate cast to intptr_t. Note
that I am assuming the incoming arg2 will always fit into 32 bit!

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17125
Build 16981: arc lint + arc unit

Event Timeline

dim created this revision.Jun 9 2018, 9:07 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 9 2018, 9:07 PM

Harbormaster completed remote builds in B17125: Diff 43524.Jun 9 2018, 9:07 PM

dim retitled this revision from Fix build of atk0110 with base gcc to Fix build of atk0110 with base gcc on i386.Jun 10 2018, 8:17 AM

Ping.

Oops, I thought I approved this, but apparently it was "only" on IRC.
I hope that your commit message will not contain "assume" and instead will state that we indeed pass a pointer via means of uintmax_t (that must not be narrower than uintptr_t) as we discussed.

This revision is now accepted and ready to land.Jun 15 2018, 8:38 PM

Closed by commit rS335296: Fix build of aibs with base gcc on i386 (authored by dim). · Explain WhyJun 17 2018, 7:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpi_support/

atk0110.c

4 lines

Diff 43524

View Options

sys/dev/acpi_support/atk0110.c

Fix build of atk0110 with base gcc on i386ClosedPublicActions