Details

Reviewers

asomers
gnn
rwatson

Commits

rS334668: audit(4): add tests for open(2) and openat(2)

Summary

The following changes introduce a new test-program open, which contains the tests for
open(2) and openat(2) system calls in various opening mode:

72:AUE_OPEN_R:open(2) - read:fr
73:AUE_OPEN_RC:open(2) - read,creat:fc,fr,fa,fm
74:AUE_OPEN_RT:open(2) - read,trunc:fd,fr,fa,fm
75:AUE_OPEN_RTC:open(2) - read,creat,trunc:fc,fd,fr,fa,fm
76:AUE_OPEN_W:open(2) - write:fw
77:AUE_OPEN_WC:open(2) - write,creat:fc,fw,fa,fm
78:AUE_OPEN_WT:open(2) - write,trunc:fd,fw,fa,fm
79:AUE_OPEN_WTC:open(2) - write,creat,trunc:fc,fd,fw,fa,fm
80:AUE_OPEN_RW:open(2) - read,write:fr,fw
81:AUE_OPEN_RWC:open(2) - read,write,creat:fc,fw,fr,fa,fm
82:AUE_OPEN_RWT:open(2) - read,write,trunc:fd,fr,fw,fa,fm
83:AUE_OPEN_RWTC:open(2) - read,write,creat,trunc:fc,fd,fw,fr,fa,fm

Similarly for openat(2) as well:

270:AUE_OPENAT_R:openat(2) - read:fr
271:AUE_OPENAT_RC:openat(2) - read,creat:fc,fr,fa,fm
272:AUE_OPENAT_RT:openat(2) - read,trunc:fd,fr,fa,fm
273:AUE_OPENAT_RTC:openat(2) - read,creat,trunc:fc,fd,fr,fa,fm
274:AUE_OPENAT_W:openat(2) - write:fw
275:AUE_OPENAT_WC:openat(2) - write,creat:fc,fw,fa,fm
276:AUE_OPENAT_WT:openat(2) - write,trunc:fd,fw,fa,fm
277:AUE_OPENAT_WTC:openat(2) - write,creat,trunc:fc,fd,fw,fa,fm
278:AUE_OPENAT_RW:openat(2) - read,write:fr,fw
279:AUE_OPENAT_RWC:openat(2) - read,write,create:fc,fw,fr,fa,fm
280:AUE_OPENAT_RWT:openat(2) - read,write,trunc:fd,fw,fr,fa,fm
281:AUE_OPENAT_RWTC:openat(2) - read,write,creat,trunc:fc,fd,fw,fr,fa,fm

Note: Testing all possible combinations of audit events in success and failure mode of
open(2) and openat(2) would have required 192 test cases. In order to limit the number
test-cases and test only the most important aspects, the audit classes have been restricted
to fr and fw only.

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17012
Build 16880: arc lint + arc unit

Event Timeline

aniketp created this revision.Jun 4 2018, 12:04 AM

Harbormaster completed remote builds in B16993: Diff 43295.Jun 4 2018, 12:04 AM

Add the missing open.c source file

Harbormaster completed remote builds in B16994: Diff 43296.Jun 4 2018, 12:06 AM

It looks ok, but it's incredibly repetitive. Do you think you could find a way to simplify it? One way would be to write macros to generate the individual test cases. libexec/tftpd/tests/functional.c takes that approach.