Page MenuHomeFreeBSD

New Port: www/archiva
ClosedPublic

Authored by joneum on Jun 3 2018, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 4:00 PM
Unknown Object (File)
Mon, Nov 25, 3:56 PM
Unknown Object (File)
Sat, Nov 23, 12:23 AM
Unknown Object (File)
Nov 19 2024, 7:22 PM
Unknown Object (File)
Nov 19 2024, 6:50 AM
Unknown Object (File)
Nov 19 2024, 5:49 AM
Unknown Object (File)
Nov 17 2024, 4:08 PM
Unknown Object (File)
Nov 15 2024, 8:55 PM
Subscribers

Details

Summary

New Port: www/archiva

Apache Archiva is an extensible repository management software that helps taking
care of your own personal or enterprise-wide build artifact repository. It is
the perfect companion for build tools such as Maven, Continuum, and ANT.

Archiva offers several capabilities, amongst which remote repository proxying,
security access management, build artifact storage, delivery, browsing, indexing
and usage reporting, extensible scanning functionality and many more!

WWW: https://archiva.apache.org

PR: 203071
Submitted by: Dušan Vejnovič <freebsd@dussan.org>
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16990
Build 16858: arc lint + arc unit

Event Timeline

The Makefile is badly ordered. See Chapter 15. Order of Variables in Port Makefiles.

www/archiva/Makefile
34

Why +=?

www/archiva/Makefile
34

Is there a guide for "+"? In the "porters-handbook" I have not found so far

www/archiva/Makefile
34

You use += when the variable is defined before and you want to append to it.

Here, I cannot see the variable being defined before, so I see += and I wonder where the mistake is. Should it be =? Should it be += because this is a master port and some slave port can set it before? Did it use to be += because of some now defunct code in the Makefile?

The only variables for which you use += in a Makefile (if they are not defined before and need appending) are the variables that you can set in make.conf like CFLAGS, CXXFLAGS, LDFLAGS, that's it.

www/archiva/Makefile
34

Thank you for your explanation. I think it's good to have the explanation of "+" and "?" could record in the handbook. Many have problems with it

www/archiva/files/patch-bin_archiva
23

%%LOCALBASE%%

44

%%LOCALBASE%%/etc

52

%%USERS%%

www/archiva/files/patch-conf_wrapper.conf
10

DIR is not defined.
%%DATADIR%%

www/archiva/Makefile
34

I do not really agree, ?= and += are make(1) syntax, set if empty and append. You should be able to know which one to use by yourself.
The porter's handbook needs to stay a general guideline of how to do things, it must not, and will not become an ISO9001 abomination.

sort Makefile
Bernards changes implemented

fix a files/patch-bin_archiva problem

www/archiva/files/patch-bin_archiva
21

^.. technically this is probably %%PREFIX%% not %%LOCALBASE%% (as they are files of this port not a dependency).

switch from %%LOCALBASE%% to %%PREFIX%% in files/patch-bin_archiva

This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2018, 10:38 AM
Closed by commit rP474069: New Port: www/archiva (authored by joneum). · Explain Why
This revision was automatically updated to reflect the committed changes.