New Port: www/archiva

[joneum]

Summary

New Port: www/archiva

Apache Archiva is an extensible repository management software that helps taking
care of your own personal or enterprise-wide build artifact repository. It is
the perfect companion for build tools such as Maven, Continuum, and ANT.

Archiva offers several capabilities, amongst which remote repository proxying,
security access management, build artifact storage, delivery, browsing, indexing
and usage reporting, extensible scanning functionality and many more!

WWW: https://archiva.apache.org

PR: 203071
Submitted by: Dušan Vejnovič <[e-mail]>
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Hey guys, can you please have a look at the new port? Thank you :-)

poudriere testport:
http://joneumbox.org/data/11-1-AMD64-ports/2018-06-03_21h48m20s/logs/archiva-2.2.3.log
http://joneumbox.org/data/11-1-i386-ports/2018-06-03_22h12m20s/logs/archiva-2.2.3.log

[mat]

The Makefile is badly ordered. See Chapter 15. Order of Variables in Port Makefiles.

www/archiva/Makefile

34 ↗

(On Diff #43290)

Why +=?

[joneum]

www/archiva/Makefile

34 ↗

(On Diff #43290)

Is there a guide for "+"? In the "porters-handbook" I have not found so far

[mat]

www/archiva/Makefile

34 ↗

(On Diff #43290)

You use += when the variable is defined before and you want to append to it.

Here, I cannot see the variable being defined before, so I see += and I wonder where the mistake is. Should it be =? Should it be += because this is a master port and some slave port can set it before? Did it use to be += because of some now defunct code in the Makefile?

The only variables for which you use += in a Makefile (if they are not defined before and need appending) are the variables that you can set in make.conf like CFLAGS, CXXFLAGS, LDFLAGS, that's it.

[joneum]

www/archiva/Makefile

34 ↗

(On Diff #43290)

Thank you for your explanation. I think it's good to have the explanation of "+" and "?" could record in the handbook. Many have problems with it

[brnrd]

www/archiva/files/patch-bin_archiva

23 ↗

(On Diff #43290)

%%LOCALBASE%%

44 ↗

(On Diff #43290)

%%LOCALBASE%%/etc

52 ↗

(On Diff #43290)

%%USERS%%

www/archiva/files/patch-conf_wrapper.conf

10 ↗

(On Diff #43290)

DIR is not defined.
%%DATADIR%%

[mat]

www/archiva/Makefile

34 ↗

(On Diff #43290)

I do not really agree, ?= and += are make(1) syntax, set if empty and append. You should be able to know which one to use by yourself.
The porter's handbook needs to stay a general guideline of how to do things, it must not, and will not become an ISO9001 abomination.

[joneum]

sort Makefile
Bernards changes implemented

[joneum]

some fixes

[joneum]

fix a files/patch-bin_archiva problem

[joneum]

ping :)

[tcberner]

www/archiva/files/patch-bin_archiva

20 ↗

(On Diff #44686)

^.. technically this is probably %%PREFIX%% not %%LOCALBASE%% (as they are files of this port not a dependency).

[joneum]

switch from %%LOCALBASE%% to %%PREFIX%% in files/patch-bin_archiva