Paths

Table of Contentst

Differential D15636

Add tests for readlink(2) and readlinkat(2) system calls
ClosedPublic
Actions

Authored by aniketp on May 31 2018, 5:31 PM.

Tags

None

Referenced Files

	F136017045: D15636.id43218.diff
	Sat, Nov 15, 3:07 AM

	F135967869: D15636.id43213.diff
	Fri, Nov 14, 4:07 PM

	F135961731: D15636.diff
	Fri, Nov 14, 2:41 PM

	Unknown Object (File)
	Fri, Nov 14, 6:00 AM

	Unknown Object (File)
	Tue, Nov 11, 12:37 AM

	Unknown Object (File)
	Fri, Nov 7, 3:08 AM

	Unknown Object (File)
	Wed, Nov 5, 3:36 AM

	Unknown Object (File)
	Tue, Nov 4, 1:30 AM

Subscribers

Details

Reviewers

asomers
gnn
rwatson

Commits

rS339087: MFC many audit(4) tests.
rS334471: audit(4): Add tests for the fr class of syscalls

Summary

The following changes introduce a new test-program file-read, apart from the already existing 24 tests for fc "file-create" audit class which were introduced in D15286 and committed as rS334360. These 4 test-cases check the proper audit of readlink(2) and readlinkat(2) for both success and failure case.

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

aniketp created this revision.May 31 2018, 5:31 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2018, 5:31 PM

Other than the copyright header, it LGTM.

tests/sys/audit/file-read.c
3	As Mateusz said, you should remove "All rights reserved"

This revision now requires changes to proceed.May 31 2018, 5:58 PM

Remove the "All Rights Reserved" from file-create.c and file-read.c

Remove "All rights reserved" from utils.c and utils.h

asomers accepted this revision.May 31 2018, 11:08 PM

This revision is now accepted and ready to land.May 31 2018, 11:08 PM

Closed by commit rS334471: audit(4): Add tests for the fr class of syscalls (authored by asomers). · Explain WhyJun 1 2018, 1:37 AM

This revision was automatically updated to reflect the committed changes.

aniketp mentioned this in D15640: Add tests for truncate(2) and ftruncate(2) system calls.Jun 1 2018, 2:21 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

audit/

3 lines

137 lines

Diff 43209

tests/sys/audit/Makefile

Loading...

tests/sys/audit/file-read.c

Loading...