Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
- helpfuk (sp)
- I think the "unmaintained ports" section should mention the PR will be *closed* if all it says is "please update port".
well, this new text basically encourages someone to submit a PR to announce a new version to an unmaintained port because "it might get picked up ...".
We really don't want to send that message.
We don't want these types of PRs at all.
If the policy is supposed to be "don't submit 'please update'" PRs (and I understand that is the new policy) then we should be explicit about it IMO.
by the way, the chances of a PR like that to an umaintained port getting picked up is slim.
For unmaintained port, unless the PR contains a real patch, they don't get picked up. Obviously a "please update" PR fits into that category.
en_US.ISO8859-1/articles/problem-reports/article.xml | ||
---|---|---|
104–105 | s/FreeBSD/&os;/ | |
105 | The aside makes this confusing, and it's hard to tell what this sentence means. I think it means this: Consider these factors when submitting PRs about ports or other software that is not part of &os; itself: | |
119–124 | This is a run-on sentence. Break it after "helpful": ...helpful. Maintainers... | |
121 | This second "automatically" is redundant. | |
122 | Passive->active: Split sentences apart: applications. So a PR only creates | |
123 | "Supplementary" has a positive connotation. "needless additional" is better. "the committers" can just be "committers". |
Update with feedback from marino@ and wblock@
Rework the list to be more straight forward and direct the user exactly what to do, and what not to do.
Thanks, you addressed my main issue! I have a tweak about how to become maintainer though.
en_US.ISO8859-1/articles/problem-reports/article.xml | ||
---|---|---|
122 | suggest changing from: I think we prefer "make me maintainer" requests via bugzilla over mail list, and we definitely want to be sure any new maintainer has a bugzilla account as a minimum requirement to be a maintainer. |