Only crop the VPN on POWER4 and derivatives for TLBIE operations
ClosedPublic
Actions

Authored by jhibbits on May 26 2018, 12:28 AM.

Details

Reviewers

nwhitehorn
breno.leitao_gmail.com
leandro.lupori_gmail.com

Commits

rS334230: Only crop the VPN on POWER4 and derivatives for TLBIE operations

Summary

PowerISA 2.03 and later require bits 14:65 in the RB register argument,
which is the full value of the vpn argument post-shift. Only POWER4, POWER4+,
and PPC970* need the upper 16 bits cropped.

With this change FreeBSD can boot to multi-user on POWER9.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16855
Build 16734: arc lint + arc unit

Event Timeline

jhibbits created this revision.May 26 2018, 12:28 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 26 2018, 12:28 AM

Harbormaster completed remote builds in B16855: Diff 43025.May 26 2018, 12:28 AM

On POWER9, I think the lock is unnecessary (the ISA spec doesn't mention it).

This revision is now accepted and ready to land.May 26 2018, 12:29 AM

In D15581#329046, @nwhitehorn wrote:

On POWER9, I think the lock is unnecessary (the ISA spec doesn't mention it).

I can revisit that later. First make it work, then make it fast.

Closed by commit rS334230: Only crop the VPN on POWER4 and derivatives for TLBIE operations (authored by jhibbits). · Explain WhyMay 26 2018, 12:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

aim/

moea64_native.c

15 lines

Diff 43025

View Options

sys/powerpc/aim/moea64_native.c

Only crop the VPN on POWER4 and derivatives for TLBIE operationsClosedPublicActions