Page MenuHomeFreeBSD
Differential D15568

Enable high-speed on the card before increasing frequency on the controller
ClosedPublic
Actions

Authored by kibab on May 25 2018, 9:46 AM.
Tags
Referenced Files
F154893524: D15568.id.diff
Wed, Apr 29, 8:15 PM
Unknown Object (File)
Wed, Apr 29, 12:50 PM
Unknown Object (File)
Tue, Apr 28, 8:53 PM
Unknown Object (File)
Mon, Apr 27, 9:58 PM
Unknown Object (File)
Mon, Apr 27, 3:40 PM
Unknown Object (File)
Thu, Apr 23, 1:36 PM
Unknown Object (File)
Tue, Apr 21, 8:56 AM
Unknown Object (File)
Wed, Apr 15, 2:08 AM
View All Files
Subscribers
None

Details

Reviewers
imp
Commits
rS334651: Enable high-speed on the card before increasing frequency on the controller
Summary

Increasing operating frequency without telling card to switch to high-speed mode first upsets some cards and generates CRC errors.
While here, deselect / reselect cards after CMD6 and SCR fetch, as in original code.

Test Plan

This diff enables normal operation for the following card: <SDHC SL16G 8.0 SN 19853490 MFG 01/2017> with Raspberry Pi 3 host.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 16838

Event Timeline

kibab created this revision.May 25 2018, 9:46 AM
Harbormaster completed remote builds in B16838: Diff 42975.May 25 2018, 9:46 AM
imp accepted this revision.Jun 4 2018, 8:27 PM

other than the minor style nits, this looks good.

sys/cam/mmc/mmc_da.c
904

style says this { is alone on the next line.

905

and no blank line here.

This revision is now accepted and ready to land.Jun 4 2018, 8:27 PM
kibab marked 2 inline comments as done.Jun 5 2018, 11:03 AM
Closed by commit rS334651: Enable high-speed on the card before increasing frequency on the controller (authored by kibab). · Explain WhyJun 5 2018, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
cam/
mmc/
70 lines

Diff 42975

View Options

sys/cam/mmc/mmc_da.c

Loading...