Page MenuHomeFreeBSD

Enable high-speed on the card before increasing frequency on the controller
ClosedPublic

Authored by kibab on May 25 2018, 9:46 AM.
Referenced Files
Unknown Object (File)
Dec 22 2023, 10:51 PM
Unknown Object (File)
Nov 6 2023, 1:42 AM
Unknown Object (File)
Oct 19 2023, 7:24 PM
Unknown Object (File)
Oct 19 2023, 5:59 PM
Unknown Object (File)
Oct 5 2023, 12:40 AM
Unknown Object (File)
Jun 25 2023, 12:17 PM
Unknown Object (File)
Jun 25 2023, 12:17 PM
Unknown Object (File)
Jun 25 2023, 12:16 PM
Subscribers
None

Details

Summary

Increasing operating frequency without telling card to switch to high-speed mode first upsets some cards and generates CRC errors.
While here, deselect / reselect cards after CMD6 and SCR fetch, as in original code.

Test Plan

This diff enables normal operation for the following card: <SDHC SL16G 8.0 SN 19853490 MFG 01/2017> with Raspberry Pi 3 host.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

other than the minor style nits, this looks good.

sys/cam/mmc/mmc_da.c
904 โ†—(On Diff #42975)

style says this { is alone on the next line.

905 โ†—(On Diff #42975)

and no blank line here.

This revision is now accepted and ready to land.Jun 4 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.