Page MenuHomeFreeBSD
Differential D15557

Make vadvise compat freebsd11.
ClosedPublic
Actions

Authored by brooks on May 24 2018, 5:16 PM.
Tags
None
Referenced Files
F132395568: D15557.id42945.diff
Thu, Oct 16, 1:39 PM
Unknown Object (File)
Sun, Oct 12, 7:45 PM
Unknown Object (File)
Wed, Oct 1, 12:08 PM
Unknown Object (File)
Sat, Sep 20, 11:47 AM
Unknown Object (File)
Fri, Sep 19, 5:00 AM
Unknown Object (File)
Sep 15 2025, 2:04 PM
Unknown Object (File)
Sep 6 2025, 7:03 PM
Unknown Object (File)
Sep 5 2025, 3:34 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
emaste
Commits
rS334223: Make vadvise compat freebsd11.
Summary

The vadvise syscall (aka ovadvise) is undocumented and has always been
implmented as returning EINVAL. Put the syscall under COMPAT11 and
provide a userspace implementation.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16820
Build 16703: arc lint + arc unit

Event Timeline

brooks created this revision.May 24 2018, 5:16 PM
Harbormaster completed remote builds in B16814: Diff 42939.May 24 2018, 5:16 PM
kib added a comment.May 24 2018, 5:35 PM

Could you, please, remove the generated files from the review and from the commit ?

brooks updated this revision to Diff 42943.May 24 2018, 5:52 PM
  • Remove generated files from review.
Harbormaster completed remote builds in B16818: Diff 42943.May 24 2018, 5:52 PM
emaste added a comment.May 24 2018, 5:55 PM

Add a dependency cleanup in Makefile.inc1 after commit also?

lib/libc/sys/vadvise.c
5

holder?

brooks updated this revision to Diff 42945.May 24 2018, 6:10 PM
  • Actually name copyright holder.
Harbormaster completed remote builds in B16820: Diff 42945.May 24 2018, 6:10 PM
brooks added a comment.May 24 2018, 6:11 PM
In D15557#328428, @emaste wrote:

Add a dependency cleanup in Makefile.inc1 after commit also?

That's the plan.

brooks marked an inline comment as done.May 24 2018, 6:11 PM
kib added inline comments.May 24 2018, 6:18 PM
lib/libc/sys/vadvise.c
38

Are __sys_vadvise and _vadvise symbols used by anything in the base system ? If no, then they can be removed, since we do not provide stable ABI in FreeBSD private namespace.

sys/vm/vm_unix.c
240

I believe this structure definition is useless.

brooks updated this revision to Diff 42949.May 24 2018, 6:35 PM
  • Nothing uses _vadvise() or __sys_vadvise so don't provide them.
  • Don't document ignored struct freebsd11_vadvise_args.
Harbormaster completed remote builds in B16823: Diff 42949.May 24 2018, 6:35 PM
kib accepted this revision.May 24 2018, 7:03 PM
This revision is now accepted and ready to land.May 24 2018, 7:03 PM
Closed by commit rS334223: Make vadvise compat freebsd11. (authored by brooks). · Explain WhyMay 25 2018, 8:40 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 25 2018, 8:40 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
1 line
47 lines
sys/
compat/
freebsd32/
3 lines
kern/
3 lines
vm/
14 lines

Diff 42945

View Options

lib/libc/sys/Makefile.inc

Loading...
View Options

lib/libc/sys/vadvise.c

Loading...
View Options

sys/compat/freebsd32/syscalls.master

Loading...
View Options

sys/kern/syscalls.master

Loading...
View Options

sys/vm/vm_unix.c

Loading...