Page MenuHomeFreeBSD

Make vadvise compat freebsd11.
ClosedPublic

Authored by brooks on May 24 2018, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 10:48 AM
Unknown Object (File)
Dec 17 2024, 2:06 AM
Unknown Object (File)
Dec 14 2024, 8:23 AM
Unknown Object (File)
Dec 6 2024, 2:38 AM
Unknown Object (File)
Nov 28 2024, 2:52 AM
Unknown Object (File)
Oct 4 2024, 11:38 AM
Unknown Object (File)
Sep 30 2024, 4:22 AM
Unknown Object (File)
Sep 24 2024, 3:44 AM
Subscribers

Details

Summary

The vadvise syscall (aka ovadvise) is undocumented and has always been
implmented as returning EINVAL. Put the syscall under COMPAT11 and
provide a userspace implementation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Could you, please, remove the generated files from the review and from the commit ?

  • Remove generated files from review.

Add a dependency cleanup in Makefile.inc1 after commit also?

lib/libc/sys/vadvise.c
4 ↗(On Diff #42943)

holder?

  • Actually name copyright holder.

Add a dependency cleanup in Makefile.inc1 after commit also?

That's the plan.

lib/libc/sys/vadvise.c
38 ↗(On Diff #42945)

Are __sys_vadvise and _vadvise symbols used by anything in the base system ? If no, then they can be removed, since we do not provide stable ABI in FreeBSD private namespace.

sys/vm/vm_unix.c
240 ↗(On Diff #42945)

I believe this structure definition is useless.

  • Nothing uses _vadvise() or __sys_vadvise so don't provide them.
  • Don't document ignored struct freebsd11_vadvise_args.
This revision is now accepted and ready to land.May 24 2018, 7:03 PM
This revision was automatically updated to reflect the committed changes.