Page MenuHomeFreeBSD
Differential D15550

Fix a memory leak on topology_parse().
ClosedPublic
Actions

Authored by araujo on May 24 2018, 9:23 AM.
Tags
None
Referenced Files
F106122616: D15550.id.diff
Wed, Dec 25, 6:56 PM
Unknown Object (File)
Fri, Nov 29, 3:27 PM
Unknown Object (File)
Thu, Nov 28, 9:08 AM
Unknown Object (File)
Sep 25 2024, 12:09 AM
Unknown Object (File)
Sep 20 2024, 9:53 PM
Unknown Object (File)
Sep 19 2024, 4:40 AM
Unknown Object (File)
Sep 17 2024, 3:13 PM
Unknown Object (File)
Sep 15 2024, 3:16 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
rgrimes
grehan
neel
tychon
jhb
anish
Commits
rS334199: Fix a memory leak on topology_parse().
Summary

strdup(3) allocates memory for a copy of the string, does the copy and returns a pointer to it. If there is no sufficient memory NULL is returned and the global errno is set to ENOMEM. We do a sanity check to see if it was possible to allocate enough memory.

Also as we allocate memory, we need to free this memory used. OR it will going out of scope leaks the storage it points to.

Test Plan

smoke tests using clang and gcc47.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16807
Build 16690: arc lint + arc unit

Event Timeline

araujo created this revision.May 24 2018, 9:23 AM
Herald added a reviewer: rgrimes. · View Herald TranscriptMay 24 2018, 9:23 AM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B16807: Diff 42921.May 24 2018, 9:23 AM
araujo edited the summary of this revision. (Show Details)May 24 2018, 9:25 AM
araujo added reviewers: grehan, neel, tychon, jhb, anish.
rgrimes accepted this revision.May 24 2018, 1:15 PM
This revision is now accepted and ready to land.May 24 2018, 1:15 PM
rgrimes added a comment.May 24 2018, 1:19 PM

Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298

araujo added a comment.May 24 2018, 1:34 PM
In D15550#328333, @rgrimes wrote:

Please mark the commit as MFC-X with https://svnweb.freebsd.org/changeset/base/332298

Hi,

Isn't it X-MFC? I got confused after see another review related with MFC after and before! But I'm almost sure it is X-MFC.

Best,

Closed by commit rS334199: Fix a memory leak on topology_parse(). (authored by araujo). · Explain WhyMay 25 2018, 2:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
11 lines

Diff 42921

View Options

usr.sbin/bhyve/bhyverun.c

Loading...