Differential D15546

Yank crufty INTR_FILTER option
ClosedPublic
Actions

Authored by cem on May 24 2018, 3:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 2, 10:02 AM

	Unknown Object (File)
	Sun, Mar 1, 6:48 AM

	Unknown Object (File)
	Mon, Feb 16, 2:31 PM

	Unknown Object (File)
	Sun, Feb 15, 10:38 PM

	Unknown Object (File)
	Tue, Feb 10, 12:13 AM

	Unknown Object (File)
	Sun, Feb 8, 3:00 PM

	Unknown Object (File)
	Sun, Feb 8, 1:11 PM

	Unknown Object (File)
	Jan 31 2026, 5:18 AM

Subscribers

Details

Reviewers

jhb
mmacy

Commits

rS334170: Yank crufty INTR_FILTER option

Summary

It was introduced to the tree in r169320 and r169321 in May 2007.

It never got much use and never became a kernel default. The code
duplicates the default path quite a bit, with slight modifications. Just
yank out the cruft. Whatever goals were being aimed for can probably be met
within the existing framework, without a flag day option.

Mostly mechanical change: 'unifdef -m -UINTR_FILTER'.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16799
Build 16684: arc lint + arc unit

Event Timeline

cem created this revision.May 24 2018, 3:49 AM

Harbormaster completed remote builds in B16799: Diff 42910.May 24 2018, 3:49 AM

mmacy accepted this revision.May 24 2018, 4:53 AM

This revision is now accepted and ready to land.May 24 2018, 4:53 AM

(rpaulo was the original author of the driver (and the INTR_FILTER cruft dates to the original commit), but he is inactive now.)

Closed by commit rS334170: Yank crufty INTR_FILTER option (authored by cem). · Explain WhyMay 24 2018, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Herald added subscribers: andrew, imp. · View Herald TranscriptMay 24 2018, 5:06 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

conf/

1 line

conf/

3 lines

dev/

asmc/

24 lines

kern/

540 lines

modules/

asmc/

2 lines

Diff 42910

sys/arm/conf/CRB

Loading...

sys/conf/options

Loading...

sys/dev/asmc/asmc.c

Loading...

sys/kern/kern_intr.c

Loading...

sys/modules/asmc/Makefile

Loading...