pf: Replace rwlock on PF_RULES_LOCK with rmlock
ClosedPublic
Actions

Authored by farrokhi on May 20 2018, 3:47 PM.

Details

Reviewers

Commits

rS334375: pf: Replace rwlock on PF_RULES_LOCK with rmlock

Summary

Given that PF_RULES_LOCK is a mostly read lock, I replaced the rwlock with rmlock.
This change improves packet processing rate in high pps environments.
While here, I am also eliminating all appearances of "sys/rwlock.h" includes since it is not used anymore.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16721
Build 16614: arc lint + arc unit

Event Timeline

farrokhi created this revision.May 20 2018, 3:47 PM

Herald added subscribers: ae, imp. · View Herald TranscriptMay 20 2018, 3:47 PM

Harbormaster completed remote builds in B16720: Diff 42769.May 20 2018, 3:47 PM

Looks good at first glance.
I like the move of the sys/rmlock.h include into pfvar.h, so the header becomes more self-contained (i.e. you don't need extra includes to make your include of pfvar.h work). I'm running test builds for that, because I thought it broke when I tried. Perhaps I messed something else up though.

For others and for context: Olivier has tested this change and saw a 65% increase in packets per second through pf. We really, really want this change.

In D15502#327153, @kristof wrote:

Looks good at first glance.
I like the move of the sys/rmlock.h include into pfvar.h, so the header becomes more self-contained (i.e. you don't need extra includes to make your include of pfvar.h work). I'm running test builds for that, because I thought it broke when I tried. Perhaps I messed something else up though.

For others and for context: Olivier has tested this change and saw a 65% increase in packets per second through pf. We really, really want this change.

For the record, here is his performance test done by @olivier: