Page MenuHomeFreeBSD

pf: Replace rwlock on PF_RULES_LOCK with rmlock
ClosedPublic

Authored by farrokhi on May 20 2018, 3:47 PM.

Details

Summary

Given that PF_RULES_LOCK is a mostly read lock, I replaced the rwlock with rmlock.
This change improves packet processing rate in high pps environments.
While here, I am also eliminating all appearances of "sys/rwlock.h" includes since it is not used anymore.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

farrokhi created this revision.May 20 2018, 3:47 PM

Looks good at first glance.
I like the move of the sys/rmlock.h include into pfvar.h, so the header becomes more self-contained (i.e. you don't need extra includes to make your include of pfvar.h work). I'm running test builds for that, because I thought it broke when I tried. Perhaps I messed something else up though.

For others and for context: Olivier has tested this change and saw a 65% increase in packets per second through pf. We really, really want this change.

farrokhi added a comment.EditedMay 20 2018, 4:23 PM

Looks good at first glance.
I like the move of the sys/rmlock.h include into pfvar.h, so the header becomes more self-contained (i.e. you don't need extra includes to make your include of pfvar.h work). I'm running test builds for that, because I thought it broke when I tried. Perhaps I messed something else up though.

For others and for context: Olivier has tested this change and saw a 65% increase in packets per second through pf. We really, really want this change.

For the record, here is his performance test done by @olivier:

farrokhi updated this revision to Diff 42770.May 20 2018, 5:41 PM

Changes in pfvar.h and removal of rwlock.h includes broke the build (noted by @kristof). This updated patch unbreaks the build.

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2018, 7:11 AM
Closed by commit rS334375: pf: Replace rwlock on PF_RULES_LOCK with rmlock (authored by kp, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.